[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kdelibs4todo # 58
From:       Michael Pyne <michael.pyne () kdemail ! net>
Date:       2006-04-25 21:39:46
Message-ID: 200604251739.46486.michael.pyne () kdemail ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 25 April 2006 08:20, Will Entriken wrote:
> #58 Places where things like "foo = new QString" seem like prime
> candidates for refactoring.
>
> I found all the cases of this using grep -nI "new QString\b" -R * |
> grep -v 'svn' and I got:
>
> kdecore/kicontheme.cpp:426:    _theme = new QString;
> kdecore/kglobalsettings.cpp:481:    s_desktopPath = new QString();
> kdecore/kglobalsettings.cpp:482:    s_autostartPath = new QString();
> kdecore/kglobalsettings.cpp:483:    s_documentPath = new QString();
> khtml/khtml_settings.cc:884:        avFamilies = new QString;
> khtml/test_regression_fontoverload.cpp:495:        avFamilies = new
> QString; kio/kio/netaccess.cpp:62:            lastErrorMsg = new QString;
> kio/kio/netaccess.cpp:434:      lastErrorMsg = new QString;
>
> What is the strategy to refactor these?

To be honest I'm not sure why this is a TODO.  Is there some problem with 
having pointers to QString, aside from the fact that it is probably not 
necessary to use pointers to QString?

Regards,
 - Michael Pyne

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]