[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] Kicker crash when clicking on K button
From:       "Jure Repinc" <jlp () holodeck1 ! com>
Date:       2006-04-25 13:37:44
Message-ID: 58406.84.52.174.5.1145972264.squirrel () 84 ! 52 ! 174 ! 5
[Download RAW message or body]

Hi,

A couple of days ago I updated the source of kdebase from SVN trunk. It
also included a change in workspace/kicker/kicker/ui/k_mnu.cpp to
convert the Qt3 function convertFromImage() to Qt4 function fromImage().
After this I got a Kicker crash when I clicked on K button to show the K
menu which I guess is because of this Qt3 to Qt4 change.

The attached patch fixes the kicker crash when clicking on K button for
me. Tested on a i686 laptop with AMD Turion 64.

What I basicly did was to change the code from:

sidePixmap.fromImage(image);

to

sidePixmap = QPixmap::fromImage(image);


-- 
JLP's Blog - http://jlp.holodeck1.com/blog/
["k_mnu.diff" (text/plain)]

Index: k_mnu.cpp
===================================================================
--- k_mnu.cpp	(revision 533007)
+++ k_mnu.cpp	(working copy)
@@ -131,7 +131,7 @@
     }
 
     Plasma::colorize(image);
-    sidePixmap.fromImage(image);
+    sidePixmap = QPixmap::fromImage(image);
 
     image.load(locate("data", "kicker/pics/" + sideTileName));
 
@@ -142,7 +142,7 @@
     }
 
     Plasma::colorize(image);
-    sideTilePixmap.fromImage(image);
+    sideTilePixmap = QPixmap::fromImage(image);
 
     if (sidePixmap.width() != sideTilePixmap.width())
     {

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]