[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: EjectPressed support for mediaIOSlave
From:       "John Tapsell" <johnflux () gmail ! com>
Date:       2006-02-28 23:48:39
Message-ID: 43d8ce650602281548t4f0bf9a2gb1563189b5aae7fd () mail ! gmail ! com
[Download RAW message or body]

Sorry for replying twice.

I just looked over the code.  You only unmount the first volume for
the device.  Is this intentional?

Also:
if(QString(condition_name) == "EjectPressed")

Maybe:
if(QByteArray(condition_name) == "EjectPressed")
is better if condition_name is a char * (I can't tell just from the patch)

Also, why is this code in HALBackend instead of whereever s_HALBackend
points to?  I don't know the code, but again just from the context it
seems that s_HALBackend is where the code should be, no?

JohnFlux

On 2/28/06, John Tapsell <johnflux@gmail.com> wrote:
> Excellent work indeed!
> I know it's a bit of a bother, but it would be great if next time you
> create a bug report with the info and the patch, then when you email
> kde-devel you can point to the bug report.
>
> Looking at bugs.kde.org I see dozens of bug reports (several dozen if
> you count those already marked as duplicates) about this.
>
> Could someone add this and forward port to kde4 (or delegate it to me)
> and I'll try to close the relevant bug reports.
>
>
>
> On 2/28/06, S.Çağlar Onur <caglar@uludag.org.tr> wrote:
> > Salı 28 Şubat 2006 22:57 tarihinde, S.Çağlar Onur şunları yazmıştı:
> > > As you may already know hal started to support eject button pressed
> events
> > > for optical drives with version 0.5.5. If anyone interested, attached
> > patch
> > > [against KDE-3.5.1] captures this events and unmounts & ejects mounted
> > > optical drive without breaking current API/ABI.
> >
> > Correct patch attached [missing include added], sorry for multiple post.
> >
> > Cheers
> > --
> > S.Çağlar Onur <caglar@uludag.org.tr>
> > http://cekirdek.uludag.org.tr/~caglar/
> >
> > Linux is like living in a teepee. No Windows, no Gates and an Apache in
> > house!
> >
> >
>
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]