[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: new in kdereview: kvpnc
From:       Frank Osterfeld <frank.osterfeld () gmx ! de>
Date:       2005-10-09 9:56:10
Message-ID: 200510091156.14829.frank.osterfeld () gmx ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi Christoph!

On Saturday 08 October 2005 14:30, Christoph Thielecke wrote:
> Hello,
>
> I'm lucky to anounce kvpnc in kde review module :)

Where is kvpnc supposed to go to? kdenetwork? extragear?

There are some things that cause headache for me:

* The UI: It's, uhm..., "complex", to say the least. The toolbar is cluttered, 
I guess you could remove everything except connect, disconnect, manage 
profiles from there. 

The configure dialog makes me dizzy (and crashes kvpnc when I cancel it):

* Why is "debug" on top of the list? That is most likely not what users want 
to configure most of the time. And why is "Dont quit by clicking close 
button" in the debug section?

* Why are profiles mixed with configuration options? Can't that stay in a 
"manage profiles" dialog? There is a "Profile" pulldown menu everywhere. So 
when configuring a specific profile using the configure dialog, I have to go 
through all pages, choose the right profile, and do the setting. So I have to 
select the _action_ first, and _then_ the profile. Actually I want to choose 
a profile, press "edit" and see all options that are relevant (and only them) 
for this profile.

* When creating a profile, it is filled with tons of options where half of it 
is disabled because it belongs to another vpn implementation. I don't want to 
see OpenVPN options when I set up a cisco vpn, these options just confuse me.
    
* What is "Save Profile" good for? Do I have to save profiles explicitely? 
That makes no sense to me. Kvpnc should just save profiles I think.

* In the implementation, I saw a lot of hardcoded paths like 

if (QFile::exists("/usr/bin/vpnc")) doFoo; else if 
((QFile::exists("/usr/local/bin/vpnc")) doBar; else "Error!"

There should be a cleaner and more portable way to find out whether a certain 
binary is available in the PATH (look at apps like k3b for inspiration).
Same goes for kernel modules and device nodes. This is hardly portable.

Enough criticsm for now ;-)
I myself would be happy to see Kvpnc more integrated in KDE. But I think some 
more polishing is needed.

Frank

[Attachment #5 (application/pgp-signature)]

 =

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscrib=
e <<


[prev in list] [next in list] [prev in thread] [next in thread]