[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [kdeaddons] noatun-plugins/blurscope compilation fix
From:       Bongani Hlope <bhlope () mweb ! co ! za>
Date:       2005-09-27 19:20:43
Message-ID: 200509272120.43268.bhlope () mweb ! co ! za
[Download RAW message or body]

On Monday 26 September 2005 22:22, Thiago Macieira wrote:
> Bongani Hlope wrote:
> > Hi
> > 
> > Could you pllease apply this patch to fix compilation problems with the
> > blurscope plugin for noatun. The `$(SDL_CONFIG) --libs` command returns
> > -L/usr/lib64 -lSDL -lpthread, which tries to link against my distro
> > installed version of kde, since it is added before /opt/kde/lib
> 
> I'm sorry, but the original code is wrong: $(SDL_CONFIG) should not be
> called by make/unsermake, but instead tested for in configure and its
> output stored in a variable like SDL_LIBS. What's more, that variable
> should be added to _LIBADD, not _LDFLAGS.
> 
> Do you think you can modify that?

My autoconf and friend knowledge is very limited. How about this patch instead?

Index: noatun-plugins/blurscope/Makefile.am
===================================================================
--- noatun-plugins/blurscope/Makefile.am        (revision 464284)
+++ noatun-plugins/blurscope/Makefile.am        (working copy)
@@ -1,9 +1,9 @@
-INCLUDES= `$(SDL_CONFIG) --cflags` $(all_includes)
+INCLUDES= $(all_includes) $(SDL_CFLAGS)

 kde_module_LTLIBRARIES = noatunblurscope.la
 noatunblurscope_la_SOURCES = sdlscope.cpp scopedisplayer.cpp
-noatunblurscope_la_LDFLAGS = -module -avoid-version -no-undefined `$(SDL_CONFIG) \
                --libs` $(all_libraries)
-noatunblurscope_la_LIBADD = $(LIB_KFILE) -lnoatun -lm
+noatunblurscope_la_LDFLAGS = -module -avoid-version -no-undefined $(all_libraries)
+noatunblurscope_la_LIBADD = $(LIB_KFILE) -lnoatun -lm $(SDL_LIBS)
 noatunblurscope_la_METASOURCES = AUTO

 noatun_DATA = blurscope.plugin
 
> > Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]