[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch for KRDC
From:       Bram Schoenmakers <bramschoenmakers () kde ! nl>
Date:       2005-09-25 19:28:54
Message-ID: 200509252128.55053.bramschoenmakers () kde ! nl
[Download RAW message or body]

Op zondag 25 september 2005 20:01, schreef Sivert Berg:

Hi there,

> Hello,
>
> I've made a patch for KRDC that make it function as a KPART. I sent a
> mail to the guy mentioned in the readme, but he isn't a KDE developer
> anymore, so I wondered if anyone in here could take a look at the patch and
> maybe commit it? All that needs to be done is add the krdcpart.* files into
> the krdc directory and change the Makefile.am in the same dir with this
> Makefile.am. I was also told to volunteer as KRDC maintainer, so I
> guess I do :)
>
> Cheers
> Sivert Berg

May I ask in what situations it's handy to have KRDC available as a KPart? I 
guess I miss something.

Some other random comments:

o A KPart also needs a *.desktop file. Did you make one?

o The version number in krdcpart.cpp (line 78) states 3.4.2. You should raise 
that to 3.5.90 or something like that. Because this patch can't be committed 
to the 3.5-branch anymore.

And last but not least. If you are really going to do some serious hacking on 
krdc, I suggest you request a SVN account.

Kind regards,

-- 
Bram Schoenmakers
KDE Netherlands (www.kde.nl)

What is mind? No matter. What is matter? Never mind.
  (Punch, 1855)
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]