[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [RFC] kdebug patch
From:       David Faure <faure () kde ! org>
Date:       2005-08-30 16:07:24
Message-ID: 200508301807.24792.faure () kde ! org
[Download RAW message or body]

On Tuesday 30 August 2005 02:23, Thomas Braxton wrote:
> On Monday 29 August 2005 05:35 pm, David Faure wrote:
> > On Monday 29 August 2005 08:42, Thomas Braxton wrote:
> > > This patch cleans up kdebug.{cpp,h}. It removes all Qt3 classes and
> > > removes all functions specified with KDE4: remove/merge, except
> > > operator<<(QStringList) because it is a subclass of QList<QString>,
> > > so I reimplemented it as such. It also moves all member variables into a
> > > d-pointer.
> >
> > I think the support for the qt3 classes will still be needed - in
> > kde3support. For easier porting of applications.
> > So, probably with a solution like the old kdebugclasses.h, which showed how
> > to add support for new types of data out of the kdebug classes themselves.
> > Would you mind doing that too? In a k3debug.h or something, which includes
> > kdebug.h and adds support for the qt3 classes. Then we can commit it all at
> > once (otherwise this commit would break compilation in many places I
> > think). I will create kde3support meanwhile.
> 
> I don't understand what you mean. There were no Qt3 classes in the interface, 
> only in the implementation. So I'm not sure what you want in k3debug.h.
> kdelibs & kdebase compile fine with this patch.

Oh! OK, sorry, I misunderstood.
No problem then.
Except that I can't apply the patch:

patching file kdebug.cpp
Hunk #6 FAILED at 496.
1 out of 7 hunks FAILED -- saving rejects to file kdebug.cpp.rej
patching file kdebug.h

Instead of me patching by hand (this hunk is very big), can you "svn update" so
that svn does the merging?
Thanks a lot.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]