[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH + FEATURE] Automatic notification of hotplugged devices
From:       Kévin_Ottens <ervin () ipsquad ! net>
Date:       2005-05-11 23:56:03
Message-ID: 200505120156.08516.ervin () ipsquad ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Jeudi 12 Mai 2005 00:59, Edwin Schepers a écrit :
> Since KDE's Media Manager starts medianotifier, I have a patch. It
> currently only works with HAL, but I guess Media Manager can be adapted so
> that it also works without HAL.

Well, I'm really not that happy with this design decision... The codes should 
be separated, in my opinion the mediamanager mustn't even be aware of the 
"medianotifier" existence.
My intended plan was to have a daemon reacting to media:/ folder changes. 
It'll be really less intrusive.

> Since the medianotifier tgz is a rough 700kb, I provide a link :
> http://members.home.nl/edwin.schepers/medianotifier/medianotifier-0.1.tgz

I'm not fully happy with the code, there's duplication, etc. But that's not 
your fault, some code needs to be factorized anyway, and I'm planning to make 
libmediacommon grow.
I'm even wondering if it shouldn't enter kdelibs... since I suspect kscd 
already uses similar patterns (it's the only application I know which is 
fully aware of media:/ urls). Comments on this are welcome.

> Eventually, I would like this program to be in kdebase (kioslave/media?).
> What are the prerequisites / steps to be taken for having it in kdebase ?

In my opinion it's too early to have it in kdebase.

> Is the first step to add it to playground/<something> ?  I think my program
> can reach relatively quick a mature state since it's a very small/simple
> program.

medianotifier by itself is "only" the program opening the window proposing the 
right actions. It's definitely needed, but not alone... I'm still trying to 
figure how to have it right usability wise. And I really think that having a 
full fledged window popping up when something is plugged/inserted is really 
intrusive/annoying... Maybe something based on KPassivePopup should be 
triggered first.

It should in my opinion enter playground, there we'll have the opportunity to 
improve it and prepare the current kdelibs/kdebase to avoid code dup, etc.
And when it's ready and non intrusive, we'll move it to kdebase (my preferred 
choice) or kdeaddons if it's not suitable for kdebase.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]