From kde-devel  Sat Mar 05 15:52:58 2005
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Sat, 05 Mar 2005 15:52:58 +0000
To: kde-devel
Subject: Re: Indentation
Message-Id: <200503050853.03963.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-devel&m=111003810700806
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0044418709=="

--===============0044418709==
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary=nextPart1411481.NfPSdSBUPF
Content-transfer-encoding: 7bit

--nextPart1411481.NfPSdSBUPF
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Saturday 05 March 2005 08:05, Anne-Marie Mahfouf wrote:
> Hi,
>
> A developer looked into my code (KHangMan in kdeedu if you want to look)
> and fixed a bug (that was cool) but he also wrote me that he never saw su=
ch
> an indentation mess before.

he's either lieing or hasn't seen much code then ;) either way, that's kind=
 of=20
a rude and non-useful thing to say to someone bout their code :/

> He did not tell me what editor he uses, I use=20
> Kate and thought my indentation was quite OK.=20

probably because kate doesn't visually show tabs... if you use an editor th=
at=20
does (and have that option turned on), you see something like this in some=
=20
parts of the code:

void KHangMan::loadSettings()
{
    *   // Language
    *   selectedLanguage =3D Prefs::selectedLanguage();
*       if (m_languages.grep(selectedLanguage).isEmpty())
*       *       selectedLanguage =3D "en";
     *  setLanguage(selectedLanguage);
    *   // Level
    *   currentLevel =3D Prefs::level(); //default is easy
     *  // Show/hide characters toolbar
   *    m_bCharToolbar =3D Prefs::showCharToolbar();
   *    if (m_bCharToolbar)
*       *       secondToolbar->show();
  *     else
*       *       secondToolbar->hide();
    *   //see if language has special accented letters
    *   setAccentBool();
    *   m_view->accent_b =3D Prefs::accentedLetters();
    *   if (m_view->m_accent && m_view->accent_b)
*       *       changeStatusbar(i18n("Type accented letters"), IDS_ACCENTS);
    *   loadDataFiles();

*       setLevel();


the stars are tabs... so, there's a mix of spaces and tabs in some areas. i=
t=20
doesn't make thing align wrong, but looks a bit odd if you view the tabs. i=
f=20
you really feel like it, you could strip the leading spaces quite easily wi=
th=20
a regular expression and be done with it. not that it's a big issue though =
=3D)

(personally, i don't use tabs in my code. i use all spaces. but that's larg=
ely=20
a personal preference)

=2D-=20
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

--nextPart1411481.NfPSdSBUPF
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBCKdXf1rcusafx20MRAskWAJ9BqSdgLuEEtXKIQFLHycW0xfIM6wCfR1yS
OE3kxx5t/Ni4BGDhAbXXbd8=
=OncP
-----END PGP SIGNATURE-----

--nextPart1411481.NfPSdSBUPF--

--===============0044418709==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============0044418709==--