[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] khtml/konqueror download manager integration
From:       David Faure <faure () kde ! org>
Date:       2005-01-30 9:46:04
Message-ID: 200501301046.05359.faure () kde ! org
[Download RAW message or body]

On Sunday 30 January 2005 03:09, Rainer Wirtz wrote:
> Am Sonntag, 30. Januar 2005 00:56 schrieb David Faure:
> > On Saturday 29 January 2005 23:13, Rainer Wirtz wrote:
> > > This patch makes konqueror behave consistent with respect to
> > > download manager integration. ATM when using RMB->save link as;
> > > RMB->save image as or <shift>+LMB then konquerors file dialog is
> > > opened and the chosen filename is handed to the download manager.
> > > Using LMB->save as (in the open with|save as|cancel dialog) opens
> > > the DLMs file dialog directly. IMO in all those cases the DLMs file
> > > dialog should be used to make use of features like default folders
> > > etc.
> > > This patch accomplishes this. Apply from within kdelibs/khtml
> >
> > The idea looks ok, but the method naming is quite confusing.
> > Why should the khtml_part code have to call saveURLbyDLM even when
> > a DLM isn't used? The method should be saveURL and it should
> > internally decide whether to use a DLM or not.
> > I guess that means finding another name for the internal "save
> > directly, without DLM" method - this could be saveURLDirect() or
> > something.
> 
> I see your point. I changed the naming to saveURL() and saveURLDirect() 
> and put a more descriptive comment into the header.

Thanks, this looks better. 
I wonder about "save background image as"  (slotSaveBackground()), 
File / "save as"   (which calls slotSaveDocument())
and "Save Frame As" (slotSaveFrame())  :
why do they use saveURLDirect instead of saveURL? Shouldn't those things
use the download manager too?
(Same question about khtmlrun). Basically I'm wondering why any code outside
of khtml_ext would want to call saveURLDirect instead of saveURL?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]