From kde-devel Mon Jan 10 10:22:28 2005 From: Lubos Lunak Date: Mon, 10 Jan 2005 10:22:28 +0000 To: kde-devel Subject: Re: make -f Makefile.cvs failes for kdeextragear-1 Message-Id: <200501101122.29287.l.lunak () suse ! cz> X-MARC-Message: https://marc.info/?l=kde-devel&m=110535257501410 On Friday 07 of January 2005 23:34, David Faure wrote: > On Friday 07 January 2005 20:42, Jonathan Brugge wrote: > > On Friday 07 January 2005 19:17, Miles Stevenson wrote: > > > gwenview/gvimageutils/Makefile.am:9: libgvimageutils_la_SOURCES was > > > already defined in condition TRUE, which implies condition > > > GV_USE_MMX_TRUE > > > > > > libgvimageutils_la_SOURCES (User, where = > > > gwenview/gvimageutils/Makefile.am:9) += > > > { > > > TRUE => \ > > > gvimageutils.cpp \ > > > jpegcontent.cpp \ > > > scale.cpp \ > > > transupp.c > > > > > > } > > > gwenview/gvimageutils/Makefile.am:9: warning: automake does not support > > > conditional definition of libgvimageutils_la_SOURCES in > > > libgvimageutils_la_SOURCES > > > Use of uninitialized value in concatenation (.) or string > > > at /usr/bin/automake-1.6 line 8449. > > > > > > : am_libgvimageutils_la_OBJECTS was already defined in condition TRUE, > > > : which > > > > > > implies condition GV_USE_MMX_TRUE > > > am_libgvimageutils_la_OBJECTS (Automake, where = undefined) = > > > { > > > TRUE => gvimageutils.lo jpegcontent.lo scale.lo transupp.lo > > > } > > > make[1]: *** [cvs] Error 1 > > > make: *** [all] Error 2 > > > > I solved this by turning the following lines in > > gwenview/gvimageutils/Makefile.am into comments: > > > > if GV_USE_MMX > > libgvimageutils_la_SOURCES += asm_scale.S > > endif > > Conditional sources are bad, from what I hear, due to dependency problems. > A solution is a subdir with a noinst_LTLIBRARIES. Coolo, any more > lightweight solution? That specific automake version that has this problem seems broken if you ask me, but I've redone it as non-conditional source, just in case. -- Lubos Lunak KDE developer --------------------------------------------------------------------- SuSE CR, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Drahobejlova 27 tel: +420 2 9654 2373 190 00 Praha 9 fax: +420 2 9654 2374 Czech Republic http://www.suse.cz/ >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<