[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: cannot remove files in Konqueror 3.4
From:       David Faure <faure () kde ! org>
Date:       2004-12-24 17:15:34
Message-ID: 200412241815.35072.faure () kde ! org
[Download RAW message or body]

On Friday 24 December 2004 16:59, Giovanni Venturi wrote:
> Alle 16:40, venerdì 24 dicembre 2004, David Faure ha scritto:
> > On Friday 24 December 2004 16:31, Giovanni Venturi wrote:
> > > Alle 16:10, venerdì 24 dicembre 2004, Christoph Wiesen ha scritto:
> > > > So, IF I'm correct and you still _can_ delete files with SHIFT+Del all
> > > > the time and by enabling the "show delete" option in the Konqueror
> > > > Settings it should actually be a good-thing to not constantly burden
> > > > the "time- or knowledge challenged user" with the constant choice to
> > > > "delete" a file or "move it to the trashcan"...
> > >
> > > No you cannot for KDE 3.4. You have to move to the trashcan and than
> > > remove it.
> >
> > Did you read what Christoph said?
> > 1) Shift+Delete works.
> No. Shift+Delete is "cut".

Indeed we have a conflict there... (strange, it works for me)

I guess we should remove Shift+Delete from Cut in konqueror.

Oh and we should create the "delete files" KAction in all cases, so that Shift+Delete
works (and configure toolbars...), just not show it in the GUI - so I gave it another name.

Please try the attached patch.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

["del.diff" (text/x-diff)]

? use_kconfigbase.diff
? listview/sizes
Index: konq_mainwindow.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/konq_mainwindow.cc,v
retrieving revision 1.1384
diff -u -p -r1.1384 konq_mainwindow.cc
--- konq_mainwindow.cc	23 Dec 2004 11:52:04 -0000	1.1384
+++ konq_mainwindow.cc	24 Dec 2004 17:15:18 -0000
@@ -36,7 +36,6 @@
 #include <konq_operations.h>
 #include <konqbookmarkmanager.h>
 #include <kinputdialog.h>
-#include <kshortcut.h>
 #include <kzip.h>
 #include <config.h>
 #include <pwd.h>
@@ -3670,6 +3669,10 @@ void KonqMainWindow::initActions()
 
   // Those are connected to the browserextension directly
   m_paCut = KStdAction::cut( 0, 0, actionCollection(), "cut" );
+  KShortcut cutShortCut = m_paCut->shortcut();
+  cutShortCut.remove( KKey( SHIFT + Key_Delete ) ); // used for deleting files
+  m_paCut->setShortcut( cutShortCut );
+
   m_paCopy = KStdAction::copy( 0, 0, actionCollection(), "copy" );
   m_paPaste = KStdAction::paste( 0, 0, actionCollection(), "paste" );
   m_paStop = new KAction( i18n( "&Stop" ), "stop", Key_Escape, this, SLOT( \
slotStop() ), actionCollection(), "stop" ); @@ -3683,6 +3686,8 @@ void \
KonqMainWindow::initActions()  KConfigGroupSaver cgs( config, "FMSettings" );
   if ( config->readBoolEntry( "ShowDeleteCommand", false ) )
     m_paDelete = new KAction( i18n( "&Delete" ), "editdelete", SHIFT+Key_Delete, \
actionCollection(), "del" ); +  else
+    m_paDelete = new KAction( i18n( "&Delete" ), "editdelete", SHIFT+Key_Delete, \
actionCollection(), "hidden_delete" );  
   m_paAnimatedLogo = new KonqLogoAction( i18n("Animated Logo"), 0, this, SLOT( \
slotDuplicateWindow() ), actionCollection(), "animated_logo" );  



>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]