[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Allow/Deny some urls to be fetch in KHTMLPart
From:       David Faure <faure () kde ! org>
Date:       2004-12-11 22:28:08
Message-ID: 200412112328.08741.faure () kde ! org
[Download RAW message or body]

On Thursday 09 December 2004 17:29, David Faure wrote:
> On Thursday 09 December 2004 17:22, John Tapsell wrote:
> > "put here because KHTMLPartPrivate, is not initialiazed when plugins is 
> > called"
> > 
> >   Won't this break bc? 
> 
> That's correct, one can't add member variables to KHTMLPart.
> 
> Also, I fixed that problem, and KHTMLPartPrivate is now initialized when plugins
> are loaded, after a discussion on kfm-devel. Oh, I haven't committed that yet.
> Ah, I remember why: it broke some kdeaddons konq plugins which suddenly
> got a working parent widget instead of 0. But those are fixed now, so I'll commit.

Maksim pointed out that this behavior change breaks existing plugins, so it might
not be a good idea. If I revert it, can you check if simply using a single-shot timer
like rellinks does, is enough to work around the problem? When the slot is called,
the KHTMLPart will be fully initialized already.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]