[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: {new title] KPDF has same problem with "zoomTo"
From:       Albert Astals Cid <tsdgeos () yahoo ! es>
Date:       2004-11-24 9:44:33
Message-ID: 200411241044.33405.tsdgeos () yahoo ! es
[Download RAW message or body]

A Dimecres 24 Novembre 2004 03:31, James Richard Tyrer va escriure:
> Albert Astals Cid wrote:
> > Hello, your patch does not compile, i get
>
> Do you mean the actual patch for KGhostView.  It built for me.

Ahhhhhh, sorry i thought that lines were for KPDF and not only quoting 
yourself on the KGhostview issue. Please accept my apologies.

>
> > kpdf_part.cpp: In constructor `KPDF::Part::Part(QWidget*, const char*,
> > QObject*, const char*, const QStringList&)':
> > kpdf_part.cpp:165: error: `zoomTo' undeclared (first use this function)
> > kpdf_part.cpp:165: error: (Each undeclared identifier is reported only
> > once for each function it appears in.)
>
> Well it appears that you are talking about KPDF.  There is no patch for
> KPDF, only a comment.  This code appears to have been taken from KGhostView
> and the error was also copied.  If the exact same fix that works with
> KGhostView doesn't work in KPDF, I don't know either.
>
> > Next time please send a patch that compiles.
>
> If it was actually a patch, I would have tested it.
>
> I apologize for forgetting the quotation marks on the string: "zoomTo".
>
> m_zoomTo = new KSelectAction(  i18n( "Zoom" ), "viewmag", "zoomTo",
> 	actionCollection(), "zoomTo" );
>
> That builds.
>
> > Also i think KSelectAction never shows an icon in the toolbar (i don't
> > have it here even if i change "zoomTo" to something that is really an
> > icon) so it does not matter (ok it is wrong but there are lots of worse
> > wrong things) if we are referring a non existant icon. Obviously i can be
> > wrong so please show me a screenshot if you can get an icon for that
> > KSelectAction.
>
> It isn't on the toolbar that the problem occurs (or would occur).  If:
> "Zoom" were in the: "View" menu then it would show the 'unknown' icon. 
> However, it isn't in the: "View" menu like it is in KGhostView.  Perhaps
> this is another issue.  However, it does show up in the: "Configure
> Toolbars" Dialog.

I'll have to check that when i reach home, thanks for thinking about it and 
reporting.

Albert

>
> --
> JRT
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]