From kde-devel Thu Oct 28 20:28:07 2004 From: David Faure Date: Thu, 28 Oct 2004 20:28:07 +0000 To: kde-devel Subject: Re: Comparing pointers via cast to int? Message-Id: <200410282228.08236.faure () kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=109899527307694 On Thursday 28 October 2004 22:15, Adriaan de Groot wrote: > For warnings-- type fixes, I was watching a base compile when this line of > konqueror (konq_mainwindow.cc:1010) generated a warning: > > if ( senderFrame && viewFrame && (uint)viewFrame != (uint)senderFrame ) Huh. Weird. > Now, senderFrame and viewFrame are both QObject *, and what's worse is that an > int isn't necessarily big enough to hold those pointers. Would either of > > if ( senderFrame && viewFrame && viewFrame != senderFrame ) Yes. Fixed, thanks. -- David Faure, faure@kde.org, sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<