--===============1122282258==
Content-Type: multipart/signed;
  boundary="nextPart1268639.HzA17FKZbU";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1268639.HzA17FKZbU
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On October 26, 2004 14:54, Christian Nitschkowski wrote:
> I made two diffs (see attached files).
> Did I get this right?
> Should I continue this way?

it's usually better to diff from the top of the source tree so we can easil=
y=20
see where the file is located.. e.g. where is searchwidget.cpp? =3D) i get =
no=20
less than 4 matches here... oop!

are you doing this work against CVS HEAD? if so (and you should be) then a=
=20
simple `cvs diff` will give you exactly what you want.

also, while you're at it there, you should cache the end(), like:

QStringList::ConstIterator itEnd =3D matches.end();
for(QStringList::ConstIterator it =3D matches.begin(); it !=3D itEnd; ++it)
     _keyList->insertItem(*it);

that should be even a bit faster =3D)

otherwise, things look good..=20

> Please CC me in your answer - I'm currently not on the list.

c'mon in, the waters fine ;-)

=2D-=20
Aaron J. Seigo
Society is Geometric

--nextPart1268639.HzA17FKZbU
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBBgBap1rcusafx20MRAvxjAJ9z9lokGK59vXhpwhx1hPhmTB2CngCgmrl1
LsAfxxGg0FaK0spgz2mKmGs=
=bKRt
-----END PGP SIGNATURE-----

--nextPart1268639.HzA17FKZbU--

--===============1122282258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--===============1122282258==--