[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Proposal to implement autohide in systemtray.
From:       Aaron Seigo <aseigo () kde ! org>
Date:       2004-10-22 20:48:44
Message-ID: 200410222250.11008.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On October 22, 2004 13:15, David Hénot wrote:
> > i do see that it doesn't follow the coding style in
> > kdebase/kicker/HACKING. 
>
> This file didn't even exist when I made my checkout and started hacking :)
> I will follow it now that I'm aware. 

thanks; yeah, i'm attempting to tame the kicker codebase =)

> 100% agreed, that's precisely what I was thinking when I said "it
> still needs some work" :)
> I will try to improve it and send you the result.

awesome =))

btw, you need to check for expandButton being instantiated in maxIconWidth as 
that gets called from getHeightForWidth / getWidthForHeight at startup and 
that may happen BEFORE expandButton gets new'd in the ctor. so... initialize 
it to 0 in the ctor initialization list and do a 

	if (expandButton && expandButton->isVisible())

i just had it crash on me because of this when logging in...

-- 
Aaron J. Seigo
Society is Geometric

[Attachment #5 (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]