[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Bug 88964 - Highlighting of files in Detailed List View
From:       Richard Smith <kde () metafoo ! co ! uk>
Date:       2004-10-16 12:22:38
Message-ID: 200410161322.38566.kde () metafoo ! co ! uk
[Download RAW message or body]

On Saturday 16 October 2004 04:56, Andre Moreira Magalhaes wrote:
>  --- Richard Smith <kde@metafoo.co.uk> escreveu:
> > Hi,
> >
> > On Saturday 16 October 2004 00:19, Andre Moreira Magalhaes wrote:
> > >  1) Make the draw of the focus rect be responsibility of the
> > > function paintCell. All the apps that reimplement paintCell to really
> > > draw the item (this is not all the cases), should draw the focus rect if
> > > appropriate. I believe that there is not a lot of apps that need this,
> > > and the change is simple.
> > [...]
> > > I believe that the first solution is more appropriate since it does not
> > > break binary compatibility
> >
> > Technically, it doesn't. Practically, it means that applications written
> > without consideration for these changes in Qt won't work properly, and
> > that applications written with consideration for these changes won't work
> > without them. Hence it breaks backwards compatibility on two counts.
>
> i agree with you, but i cannot think in a better solution. do you?

I think solution #2 is better. All applications that reimplement paintCell() 
should really reimplement width() anyway, since:
1) it says so in the Qt documentation
2) if you don't, the clickable region is likely to be wrong
I don't see how solution #2 would break any kind of compatibility.

> > Also, what should Kopete do?
[...]
> i'm using the patch and kopete 0.9.0 and it works fine to me. The items
> in contact list are rectangular.

Try switching to a different contact list view mode. The point here (which I 
should have stated more clearly) was: the solution for Kopete would be 
different to the solution most other places. In Konqueror, you'd see the 
highlight rectangle reduced to fit the icon and text (the right-clicking 
area). In Kopete, you'd see the right-clicking area expanded (it already is) 
to fit the highlight rectangle (which would be the whole item).

Perhaps a more consistent solution would be to expand the right-clicking area 
to include the white space after the text in all listview items (in detailed 
mode)? This would be consistent with the way the current rubberband selection 
works, consistent with the way left-clicking to select works, and would 
remove the surprise when right-clicking on a selected region unselects it and 
brings up the nothing-selected popup menu.
-- 
Thanks,
Richard
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]