[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [patch] to add "close on click" functionality to konqueror
From:       Kévin_'ervin'_Ottens <ervin () ipsquad ! net>
Date:       2004-07-19 13:12:37
Message-ID: 200407191512.37754.ervin () ipsquad ! net
[Download RAW message or body]

Hi,

The whole idea sounds interesting.

But something is worrying me a little in you patch.

+	if (KonqFMSettings::settings()->alwaysNewWin() && 
+	    KonqFMSettings::settings()->clickExit())

I don't understand why the "exit on click" works only if the "always new win" 
is activated too...

IMHO it should be :
+	if (KonqFMSettings::settings()->clickExit())

When you "exit on click" you have to exit and to open a new win in any case...

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]