[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KGet Patch
From:       Marcus Camen <mcamen () mcamen ! de>
Date:       2004-04-27 14:06:03
Message-ID: 200404271606.07414.mcamen () mcamen ! de
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 27 April 2004 15:23, Tim Edwards wrote:
> Using gcc 3.3 and the KDE 3.1 Branch (on a KDE 3.1 system) I get an
> error message "transfer.cpp:760: error: call of overloaded
> `writeEntry(const char[10], filesize_t&)' is ambiguous" followed by a
> list of KConfigBase::writeEntry prototypes. Casting to QVariant seems
> to prevent this.

Ah, ok. Seems to be KDE 3.1 specific then. I only tested KDE 3.2+.



> I've removed the cast to double, I don't know why it was in there :)

KDE_3_2_BRANCH, gcc 3.3.2, Qt 3.3.1:

transfer.cpp:578: error: ISO C++ says that `QString QString::arg(long
   long unsigned int, int, int) const' and `QString QString::arg(double,
   int, char, int) const' are ambiguous even though the worst conversion
   for the former is better than the worst conversion for the latter

With the double cast everything is fine.


The same happens with your change
  -  logMessage(i18n("foo"),arg(totalSize));
  +  logMessage(i18n("foo"),arg(totalSize,0,'f');

CVS HEAD, gcc 3.4, qt-copy:

/home/camen/src/kde/kdecvs/kdenetwork/kget/transfer.cpp:611: Fehler: ISO 
C++ says that these are ambiguous, even though the worst conversion for 
the first is better than the worst conversion for the second:
/home/camen/src/kde/qt-copy/include/qstring.h:432: Anmerkung: candidate 1: 
QString QString::arg(Q_ULLONG, int, int) const
/home/camen/src/kde/qt-copy/include/qstring.h:438: Anmerkung: candidate 2: 
QString QString::arg(double, int, char, int) const



> I've remade the patch file with -bup. I'll make a 3.2 and HEAD patch
> once I install Mandrake 10.0 so I have a KDE 3.2 to test it on.

Oh this is not necessary. I already have the patches in my two trees and 
the changes for 3.2 and HEAD are minimal.



> How's the best way of going about getting this committed? Should I try
> asking the authors again or should I just ask for CVS access so I can
> do it myself?

You can report a bug and attach the patch to the bug. An email to the 
relevant people will automatically generated.

In this case I think Alex (or myself if Alex is busy) will simply commit 
your changes.


- --
Marcus



>
> On Tue, 2004-04-27 at 05:25, Alexander Neundorf wrote:
> > On Monday 26 April 2004 12:00, kde-devel-request@mail.kde.org wrote:
> > > I originally sent this message to the authors:
> >
> > .. and you didn't get response ?
> >
> > Patch looks good, some small questions:
> > > Hi,
> > >
> > > While using KGet I've noticed that when the total size of all the
> > > files being downloaded is over ~2gb (i.e the highest number in
> > > bytes that a 32-bit signed int can represent) it doesn't display
> > > the total size correctly in the task bar.
> > >
> > > I've created a patch to solve this problem (see attachment). If you
> > > agree with it I hope you can integrate it into the KDE CVS module
> > > for KGet.
> >
> > What is the QVariant cast needed for ?
> > Why do you convert the file size to double ?
> >
> > > Note: This patch was created on the KDE_3_1_BRANCH of
> > > kdenetwork/kget from the KDE.org CVS.
> > >
> > > Thanks
> > > Feel free to contact me
> >
> > Can you please use the options "-bup" when creating the patch ?
> >
> > Bye
> > Alex
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAjmjOlP3stiSSHvoRAgPgAKCSLkPnKhNL57Vr1+9G/hiRLCeuMwCgksxB
MesVm0IiXNnwal3o+9Ec320=
=aGXS
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]