[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: KAboutData: setLicenseType()?
From: Gioele Barabucci <ml () gioelebarabucci ! com>
Date: 2004-02-21 14:44:09
Message-ID: 200402211544.09887.ml () gioelebarabucci ! com
[Download RAW message or body]
KAboutData is unbalanced (there is probably a better adjective to describe its
situation): in the ctor you can set "shortDescription", "licenseType",
"homePage" and other values that is not possible to set later.
There is not a setDescription(QString) or a setLicenseType(Licenses).
Can I add them? They are trivial.
Can I also apply the attached patch? it removes the initial "\n\n" from
License text if no additiona copyright is specified. The patch is really
simple, but I don't like to commit to kdecore/ without approvation :)
--
Gioele
["kaboutdata_without_blank_lines.patch" (text/x-diff)]
Index: kaboutdata.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kaboutdata.cpp,v
retrieving revision 1.19
diff -u -3 -p -r1.19 kaboutdata.cpp
--- kaboutdata.cpp 30 Dec 2003 21:39:27 -0000 1.19
+++ kaboutdata.cpp 21 Feb 2004 14:23:31 -0000
@@ -298,7 +298,10 @@ KAboutData::otherText() const
QString
KAboutData::license() const
{
- QString result = copyrightStatement() + "\n\n";
+ QString result;
+ if (!copyrightStatement().isEmpty())
+ QString result = copyrightStatement() + "\n\n";
+
QString l;
QString f;
switch ( mLicenseKey )
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic