[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] KStringHandler::obscure
From:       Szombathelyi_György <gyurco () freemail ! hu>
Date:       2003-11-25 10:34:04
[Download RAW message or body]

Cornelius Schumacher wrote:

> On Monday 24 November 2003 20:46, Szombathelyi György wrote:
> 
>>Here's a patch for KStringHandler::obscure(). Current version in CVS
>>doesn't work at all.
> 
> 
> What do you mean by "doesn't work at all"
> 
It simply creates a string which is not usable. It created a string 
which consists of identical characters. I noticed it when experimented 
with the LDAPKIO resource.

If I remember (only can check at home), changeing
QChar( 0x1001F - str.unicode()[ i ] )
to
( QChar( 0x1001F ) - str[ i ].unicode() )
did the job, too.

Maybe it's a problem with my compiler (gcc from Fedora Core1)

> 
>>My version also changes the algorithm somewhat, so 
>>identical charaters will be encoded to different chars. I hope it's not a
>>problem, since the function is new in 3.2.
> 
> 
> The function is new in kdelibs, but the algorithm was used before. If you 
> change it in a way that it can't correctly read what was written with the old 
> algorithm many applications (e.g. KMail or KAddressBook) will loose their 
> stored passwords. That's obviously not acceptable.
> 

Then it's really not acceptable.

Regards, György


 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]