[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch for kpercentage.
From:       Laurent Montel <montel () kde ! org>
Date:       2003-11-13 9:08:57
[Download RAW message or body]

On Thursday 13 November 2003 02:32, Oswald Buddenhagen wrote:
> On Thu, Nov 13, 2003 at 01:00:58AM +0100, Laurent Montel wrote:
> > Le Thursday 13 November 2003 00:48, Oswald Buddenhagen a écrit :
> > > not must, but can. saves memory, is faster.
> > > simply use 'this' as the parent and use it for all three line edits.
> >
> > Ok I understand.
> > So it's right it's better.
> >
> > I created a new patch
>
> yup. even though i'd put the creation of the validator before the first
> block to make things look uniformly. :)

Ok no problem I will change it.

> btw, i don't comment about the semanticts of the patch, as i don't even
> know what this app is for. :)=
> for the record, this is the type of patch i consider the review
> compulsion ridiculous for.

I know ..

> on the bright side, you learned something. 
>
> :)

:)
Thanks
Regards

> greetings
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]