[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KBackground KCM spinbox awkwardness patch
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2003-09-28 22:47:04
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 28 September 2003 12:28, Jason Keirstead wrote:
> On September 25, 2003 02:15 pm, Aaron J. Seigo wrote:
> >  o why is prog.setRefresh hard coded to 1440 in
> > KProgramEditDialog::slotOk()? shouldn't it be set to the value of mins?
>
> I have no idea, I didnt touch any of that. All I even looked at was the UI
> to set the time interval, and removing the goofy hardcoded limits. I really
> don't have any clue as to how the rest of the process works.

from your patch:

- -    prog.setRefresh(m_RefreshEdit->value());
+    prog.setRefresh(1440);

> >  o having the Slide Show button disabled until it is "Set up" seems
> > rather backwards. i'd expect it to be the other way around: the Setup Up
> > button is disabled until the Slide Show radio is selected
>
> See above, no idea about any of this, doesnt really have anything to do
> with the patch.

yes, this was a random comment. i need to find time to fix this; and 
unfortunately i seem to have close to none right now =( maybe i should just 
shout out to the person who committed that in the first place =)

> >  o the combined hour/minute spinner is not a very effective UI element.
> > it's hidden that you click on the hours then the minutes; the arrows
> > silently control both... not good. the Configure Date & Time control
> > panel uses separate spinners for hour/minute/seconds for this very
> > reason. please consider doing the same.
>
> If its not a very good UI element why does it exist both in QT and as a KDE
> element?

*shrug* because people make mistakes?

and now we keep it for binary/source compatibility ....

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/d2Tr1rcusafx20MRAtVvAJ0Sk8p+zrA0hhFsy08f1eTFofvdeACfQU1O
LbxvYsTaElHLNVE6DBx1dH0=
=ClGn
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]