From kde-devel Sun Sep 07 08:31:02 2003 From: Stephan Kulow Date: Sun, 07 Sep 2003 08:31:02 +0000 To: kde-devel Subject: Re: [patch] request for review - apidox for kdelibs/kdeui (long) X-MARC-Message: https://marc.info/?l=kde-devel&m=106292360120007 Am Sunday 07 September 2003 08:46 schrieb Brad Hards: > There are four sorts of changes: > 1. #ifdef in some .cpp files to make the implementation match the interface Definitly no way: you're removing functions. > 2. Fixes for some missing entries Fine. > 3. Placeholders for the rest of the missing entries Definitly no way: if you want to fix doxygen warnings, document the functions, don't add placeholders. > 4. Minor fixups / reformatting that occurred in the process of the first > three. Fine. Please split up your patch, so that we can apply 2. and 4. Greetings, Stephan -- Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平 Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini שלום Peoch Shanti Vrede Baris Rój Mír Taika Rongo Sulh Py'guapy 평화 >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<