From kde-devel  Thu Aug 14 21:45:37 2003
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Thu, 14 Aug 2003 21:45:37 +0000
To: kde-devel
Subject: Re: [Patch] #48264: added a Today button in kdatepicker
X-MARC-Message: https://marc.info/?l=kde-devel&m=106089815114417

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 14 August 2003 02:35, Martin Koller wrote:
> General question: What is the policy regarding modification of the API from
> 3.1 to 3.2 ?

http://developer.kde.org/documentation/library/kdeqt/kde3arch/devel-
binarycompatibility.html

> In this case I would change a protected slot (e.g. selectWeekClicked()) to
> selectWeekClicked(const QString &)
> Or shall I (to be code compatible) leave the old slot, which then does
> nothing ?

hrm... well, personally i wouldn't use a KComboBox, i'd keep it a pushbutton 
and simply add a popup to it using setPopup(QPopup*)... comboboxes tend to 
take up more space; the button is a good UI element IMHO, it just needs a 
popup menu rather than a popup lineedit...

regardless, the existing slot needs to remain. perhaps it would be best if it 
were called prior to showing the menu (e.g. aboutToShow()) in case someone 
has subclassed it and reimplemented the slot to do some pre-processing? of 
course, if anyone has subclassed it and reimplemented the slot without 
calling the parent's implementation (in order to do their own selection 
stuff), then that would be problematic, i suppose.

perhaps one way to do it would be to connect QPushButton::aboutToShow() to 
selectWeekClicked() and set up the menu in there?

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/PAMB1rcusafx20MRAgbHAKCdGBI/sMku3HQQMKWR3Sk9Xqa83wCfVfui
EC3E9Y21Q57O+OkG39Xo9m0=
=M8t0
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<