[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [Patch] #48264: added a Today button in kdatepicker
From:       Martin Koller <m.koller () surfeu ! at>
Date:       2003-08-14 20:35:33
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 14 August 2003 21:30, Aaron J. Seigo wrote:
> On Thursday 14 August 2003 12:45, Martin Koller wrote:
> > 2) without autoraise:
> > http://members.aon.at/m.koller/kdatepicker-noautoraise.png
>
> looks nice =)

OK, so I'll keep that.

>
> > Question regarding icons: What icons can I assume to be existing when a
> > user did only install kdelibs ?
> > Are all icons in the pics/ subdirs ?
>
> AFAIK, yes...
>
> > Regarding the week-button: I think that a button which pops up a
> > textfield to input a week number is a bad choice.
> > What do you think about changing this to a ComboBox ?
>
> i think that would be a good idea..

>
> > And for me it's also not clear, why the month selection works in a very
> > uncommon way with a special popup. Why not using a Combobox here again?
>
> agreed.
>
> > Even the year selection could use a spinbox instead of a popup.
>
> agreed.

OK, I will prepare a new patch including this.

General question: What is the policy regarding modification of the API from 
3.1 to 3.2 ?
In this case I would change a protected slot (e.g. selectWeekClicked()) to 
selectWeekClicked(const QString &)
Or shall I (to be code compatible) leave the old slot, which then does 
nothing ?
I would suggest to have these slots private.

- -- 
Best regards/Schöne Grüße

Martin

Public key at:
http://blackhole.pca.dfn.de:11371/pks/lookup?op=get&search=0x8DFB0F86
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/O/KVHmdPoI37D4YRAmjhAJ0Ws/WD7oRsh30wO58wo7jq0lVqSQCgleSJ
YXLkJwnox3p7KfC9oge0VqU=
=l02f
-----END PGP SIGNATURE-----

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]