From kde-devel  Wed Aug 13 14:48:11 2003
From: Martin Koller <m.koller () surfeu ! at>
Date: Wed, 13 Aug 2003 14:48:11 +0000
To: kde-devel
Subject: [Patch] Usability improved in windowlist/kicker
X-MARC-Message: https://marc.info/?l=kde-devel&m=106078630430504
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_r+kO/MOJ5w0H4M6"


--Boundary-00=_r+kO/MOJ5w0H4M6
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

I attach here a usability patch for the windowlist shown from kicker.

What I always was disappointed with, was that the window-titles were cut, a=
nd=20
if I have some windows opened (e.g. Xterms, konqueror, etc.) which have a=20
very similar starting part (e.g. the path) in the title, the text which was=
=20
shown in the windowlist was useless to be able to select the correct window.

As the taskbar already can group windows, and when clicking on such a group=
 I=20
get a popup with also the full window titles, I think there is no reason to=
=20
cut the text in the windowlist.

Therefore the attached patch (against 3.2 Head) solves this usability probl=
em.

You can have a look at
http://members.aon.at/m.koller/winlist-long1.png
to see how this looks like.

If you have no objections, please commit the patch, as I have no CVS rights.
Thanks,
=2D --=20
Best regards/Sch=F6ne Gr=FC=DFe

Martin

Public key at:
http://blackhole.pca.dfn.de:11371/pks/lookup?op=3Dget&search=3D0x8DFB0F86
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/Ok+wHmdPoI37D4YRAiXCAJ4qSk5LO5khHd4jVDJF7G0PZIqNmwCgppP7
nS76muTXXyqTGCsLsy8+5BY=3D
=3Do026
=2D----END PGP SIGNATURE-----

--Boundary-00=_r+kO/MOJ5w0H4M6
Content-Type: application/octet-stream;
  name="patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="patch"

? patch
Index: kwindowlistmenu.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kwindowlistmenu.cpp,v
retrieving revision 1.21
diff -u -3 -p -r1.21 kwindowlistmenu.cpp
--- kwindowlistmenu.cpp	2 Jul 2003 14:03:54 -0000	1.21
+++ kwindowlistmenu.cpp	13 Aug 2003 14:17:56 -0000
@@ -213,7 +213,7 @@ void KWindowListMenu::init()
 
         for (KWin::WindowInfo* info = list.first(); info!=0; info = list.next(), i++)
         {
-            QString title = info->visibleNameWithState();
+            QString itemText = info->visibleNameWithState();
             NET::WindowType windowType = info->windowType( NET::NormalMask | NET::DesktopMask
                 | NET::DockMask | NET::ToolbarMask | NET::MenuMask | NET::DialogMask
                 | NET::OverrideMask | NET::TopMenuMask | NET::UtilityMask | NET::SplashMask );
@@ -224,10 +224,9 @@ void KWindowListMenu::init()
                 items++;
                 if (items == 1 && nd > 1)
                     insertSeparator();
-		QString itemText =  KStringHandler::csqueeze(title,25);
 		// Avoid creating unwanted accelerators.
 		itemText.replace("&", "&&");
-                insertItem( pm, QString("   ")+ itemText, i);
+                insertItem( pm, itemText, i);
                 map.insert(i, info->win());
                 if (info->win() == active_window)
                     setItemChecked(i, TRUE);

--Boundary-00=_r+kO/MOJ5w0H4M6
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

--Boundary-00=_r+kO/MOJ5w0H4M6--