[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Release: Music Manager Konqueror Plugin
From:       "Aaron J. Seigo" <aseigo () olympusproject ! org>
Date:       2003-07-10 19:40:29
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 09 July 2003 07:25, Avi wrote:
> It is still beta, but please comment.

looks interesting... some comments:

o i had to add stdlib.h and math.h musicman/musicindexgenerator.cpp to get it 
to compile (SuSe 8.2)

o i notice you are using scandir and friends. any reason you aren't using 
KDirLister (or even QDir) to accomplish this? would likely clean up the code 
a bit and make it more robust

o the dialogs are QDialog subclasses using Qt Designer UI layouts. this causes 
things like non-standard button layouts. instead the layouts should be 
subclasses of QWidget, and musicman should use KDialogBase to show those 
widgets.

o I agree with Christian that the items should go in a submenu.

o the musicman.desktop file needs be instaled in $KDEDIR/share/services/

this also show a problem with the new Actions submenu: it doesn't put 
konqpopupplugins in there .. oops! i'll fix this shortly...

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE: The 'K' is for 'kick ass'
http://www.kde.org       http://promo.kde.org/3.1/feature_guide.php
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/DcEu1rcusafx20MRAif/AKCOgSDp3BNtQ5o70m4fZ+6h0UczZgCgqjVS
K4Wf+qjLjXWJD2b8KiXxC50=
=ZsIW
-----END PGP SIGNATURE-----
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]