[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] kdelibs/kate kdebase/kate UI Inconsistency OK APPLY buttons
From:       Willy De la Court <Willy.DelaCourt () pandora ! be>
Date:       2003-04-01 13:51:25
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patch comments
- ------------------------------------------------------
UI Inconsistency OK APPLY buttons
Apply diabled when nothing is changed
Ok only saves when something is changed
- ------------------------------------------------------

I'll wait 2 days for comments on this before commiting.

- -- 
Simple things make people happy.
Willy De la Court
PGP Public Key at http://www.linux-lovers.be/download/public_key.asc
PGP Key fingerprint = 784E E18F 7F85 9C7C AC1A D5FB FE08 686C 37C7 A689
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+iZld/ghobDfHpokRAoGtAJ421KKrq5VHFGFQZ3cHD4l2Gds5xwCg5EJQ
ziYiwRmdgf2onChiBJY+yuk=
=t0n9
-----END PGP SIGNATURE-----

["kdebase_kate.applyop.patch" (text/x-diff)]

Index: app/kateconfigdialog.cpp
===================================================================
RCS file: /home/kde/kdebase/kate/app/kateconfigdialog.cpp,v
retrieving revision 1.59
diff -u -p -r1.59 kateconfigdialog.cpp
--- app/kateconfigdialog.cpp	22 Mar 2003 23:43:30 -0000	1.59
+++ app/kateconfigdialog.cpp	1 Apr 2003 13:45:44 -0000
@@ -111,6 +111,7 @@ KateConfigDialog::KateConfigDialog (Kate
         "If this is enabled Kate will attempt to reopen files that were open when \
                you closed "
         "last time. Cursor position will be recovered if possible. Non-existent \
files will "  "not be opened."));
+  connect( cb_reopenFiles, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
 
   //config->setGroup("General");
   // restore view  config
@@ -119,6 +120,7 @@ KateConfigDialog::KateConfigDialog (Kate
   cb_restoreVC->setChecked( config->readBoolEntry("restore views", false) );
   QWhatsThis::add(cb_restoreVC, i18n(
         "Check this if you want all your views and frames restored each time you \
open Kate")); +  connect( cb_restoreVC, SIGNAL( toggled( bool ) ), this, SLOT( \
slotChanged() ) );  
   // How instances should be handled
   cb_singleInstance = new QCheckBox(frGeneral);
@@ -130,6 +132,7 @@ KateConfigDialog::KateConfigDialog (Kate
         "If this is unchecked, Kate will only use one UNIX process. If you try \
                running it again, the current "
         "process will get the focus, and open any files you requested to be opened. \
If it is checked, each time "  "you start Kate, a new UNIX process will be started.") \
); +  connect( cb_singleInstance, SIGNAL( toggled( bool ) ), this, SLOT( \
slotChanged() ) );  
   // show full path in title
   config->setGroup("General");
@@ -137,6 +140,7 @@ KateConfigDialog::KateConfigDialog (Kate
   lo->addWidget( cb_fullPath );
   cb_fullPath->setChecked( config->readBoolEntry("Show Full Path in Title", false ) \
);  QWhatsThis::add(cb_fullPath,i18n("If this option is checked, the full document \
path will be shown in the window caption.")); +  connect( cb_fullPath, SIGNAL( \
toggled( bool ) ), this, SLOT( slotChanged() ) );  
   // opaque resize of view splitters
   cb_opaqueResize = new QCheckBox( frGeneral );
@@ -146,6 +150,7 @@ KateConfigDialog::KateConfigDialog (Kate
   QWhatsThis::add( cb_opaqueResize, i18n(
         "If this is disabled, resizing views will display a <i>rubberband</i> to \
show the "  "new sizes until you release the mouse button.") );
+  connect( cb_opaqueResize, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) \
);  
   // sync the konsole ?
   cb_syncKonsole = new QCheckBox(frGeneral);
@@ -156,6 +161,7 @@ KateConfigDialog::KateConfigDialog (Kate
         "If this is checked, the built in Konsole will <code>cd</code> to the \
                directory "
         "of the active document when started and whenever the active document \
changes, "  "if the document is a local file.") );
+  connect( cb_syncKonsole, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
 
   // sync the konsole ?
   cb_sortFiles = new QCheckBox(frGeneral);
@@ -164,6 +170,7 @@ KateConfigDialog::KateConfigDialog (Kate
   cb_sortFiles->setChecked(parent->filelist->sortType() == \
KateFileList::sortByName);  QWhatsThis::add( cb_sortFiles, i18n(
         "If this is checked, the files in the file list will be sorted \
alphabetically.") ); +  connect( cb_sortFiles, SIGNAL( toggled( bool ) ), this, SLOT( \
slotChanged() ) );  
   // number of recent files
   QHBox *hbNrf = new QHBox( frGeneral );
@@ -178,6 +185,7 @@ KateConfigDialog::KateConfigDialog (Kate
         "some items forgotten.</qt>") );
   QWhatsThis::add( lNrf, youwouldnotbelieveit );
   QWhatsThis::add( sb_numRecentFiles, youwouldnotbelieveit );
+  connect( sb_numRecentFiles, SIGNAL( valueChanged ( int ) ), this, SLOT( \
slotChanged() ) );  
   KSeparator *sep=new KSeparator(frGeneral);
   sep->setOrientation(KSeparator::HLine);
@@ -193,6 +201,7 @@ KateConfigDialog::KateConfigDialog (Kate
 
   config->setGroup("General");
   cb_mode->setCurrentItem((config->readEntry("viewMode",DEFAULT_STYLE)=="Modern")?0:1);
 +  connect( cb_mode, SIGNAL( activated ( int ) ), this, SLOT( slotChanged() ) );
 
   lo->addStretch(1); // :-] works correct without autoadd
   // END General page
@@ -207,12 +216,14 @@ KateConfigDialog::KateConfigDialog (Kate
                               BarIcon("fileopen", KIcon::SizeSmall) );
   fileSelConfigPage = new KFSConfigPage( page, "file selector config page",
                                          mainWindow->fileselector );
+  connect( fileSelConfigPage, SIGNAL( changed() ), this, SLOT( slotChanged() ) );
 
   path.clear();
   path << i18n("Application") << i18n("Plugins");
   /*QVBox **/page=addVBoxPage(path,i18n("Plugin Manager"),
                           BarIcon("misc",KIcon::SizeSmall));
-  (void)new KateConfigPluginPage(page, this);
+  KateConfigPluginPage *configPluginPage = new KateConfigPluginPage(page, this);
+  connect( configPluginPage, SIGNAL( changed() ), this, SLOT( slotChanged() ) );
 
   // editor widgets from kwrite/kwdialog
   path.clear();
@@ -226,7 +237,9 @@ KateConfigDialog::KateConfigDialog (Kate
     /*QVBox **/page = addVBoxPage(path, KTextEditor::configInterfaceExtension \
                (v->document())->configPageFullName (i),
                               KTextEditor::configInterfaceExtension \
(v->document())->configPagePixmap(i, KIcon::SizeSmall) );  
-    editorPages.append (KTextEditor::configInterfaceExtension \
(v->document())->configPage(i, page)); +    KTextEditor::ConfigPage *cPage = \
KTextEditor::configInterfaceExtension (v->document())->configPage(i, page); +    \
connect( cPage, SIGNAL( changed() ), this, SLOT( slotChanged() ) ); +    \
editorPages.append (cPage);  }
 
   #if 0
@@ -241,6 +254,8 @@ KateConfigDialog::KateConfigDialog (Kate
   }
 
   enableButtonSeparator(true);
+  dataChanged = false;
+  enableButton(Apply, false);
 }
 
 KateConfigDialog::~KateConfigDialog()
@@ -283,13 +298,11 @@ void KateConfigDialog::removePluginPage 
   }
 }
 
-int KateConfigDialog::exec()
+void KateConfigDialog::slotOk()
 {
-  int n = KDialogBase::exec();
-  if (n)
+  if( dataChanged )
     slotApply();
-
-  return n;
+  accept();
 }
 
 void KateConfigDialog::slotApply()
@@ -333,4 +346,12 @@ void KateConfigDialog::slotApply()
   {
     pluginPages.at(i)->page->apply();
   }
+  dataChanged = false;
+  enableButton(Apply, false);
+}
+
+void KateConfigDialog::slotChanged()
+{
+  dataChanged = true;
+  enableButton(Apply, true);
 }
Index: app/kateconfigdialog.h
===================================================================
RCS file: /home/kde/kdebase/kate/app/kateconfigdialog.h,v
retrieving revision 1.18
diff -u -p -r1.18 kateconfigdialog.h
--- app/kateconfigdialog.h	22 Mar 2003 23:43:30 -0000	1.18
+++ app/kateconfigdialog.h	1 Apr 2003 13:45:44 -0000
@@ -45,14 +45,14 @@ class KateConfigDialog : public KDialogB
     KateConfigDialog (KateMainWindow *parent, const char * = 0);
     ~KateConfigDialog ();
 
-    int exec ();
-
   public:
     void addPluginPage (Kate::Plugin *plugin);
     void removePluginPage (Kate::Plugin *plugin);
 
   protected slots:
     virtual void slotApply();
+    virtual void slotOk();
+    void slotChanged();
 
   private:
     class KConfig *config;
@@ -62,6 +62,7 @@ class KateConfigDialog : public KDialogB
     KateMainWindow *mainWindow;
 
     Kate::View* v;
+    bool dataChanged;
 
     class QCheckBox* cb_opaqueResize;
     class QCheckBox* cb_reopenFiles;
Index: app/kateconfigplugindialogpage.cpp
===================================================================
RCS file: /home/kde/kdebase/kate/app/kateconfigplugindialogpage.cpp,v
retrieving revision 1.12
diff -u -p -r1.12 kateconfigplugindialogpage.cpp
--- app/kateconfigplugindialogpage.cpp	2 Dec 2002 22:30:34 -0000	1.12
+++ app/kateconfigplugindialogpage.cpp	1 Apr 2003 13:45:44 -0000
@@ -164,6 +164,7 @@ KateConfigPluginPage::KateConfigPluginPa
 		loadPlugin(item);
 	else
 		unloadPlugin(item);
+	emit changed();
 }
                       
 void KateConfigPluginPage::loadPlugin (PluginListItem *item)
Index: app/kateconfigplugindialogpage.h
===================================================================
RCS file: /home/kde/kdebase/kate/app/kateconfigplugindialogpage.h,v
retrieving revision 1.5
diff -u -p -r1.5 kateconfigplugindialogpage.h
--- app/kateconfigplugindialogpage.h	2 Dec 2002 22:30:34 -0000	1.5
+++ app/kateconfigplugindialogpage.h	1 Apr 2003 13:45:44 -0000
@@ -88,6 +88,9 @@ class KateConfigPluginPage: public QVBox
     KatePluginManager *myPluginMan;
     class KateConfigDialog *myDialog;
 
+  signals:
+    void changed();
+
   private slots:
     void stateChange(PluginListItem *, bool);
     
Index: app/katefileselector.cpp
===================================================================
RCS file: /home/kde/kdebase/kate/app/katefileselector.cpp,v
retrieving revision 1.24
diff -u -p -r1.24 katefileselector.cpp
--- app/katefileselector.cpp	30 Mar 2003 01:57:21 -0000	1.24
+++ app/katefileselector.cpp	1 Apr 2003 13:45:44 -0000
@@ -529,12 +529,20 @@ KFSConfigPage::KFSConfigPage( QWidget *p
   acSel->setAvailableLabel( i18n("A&vailable actions:") );
   acSel->setSelectedLabel( i18n("S&elected actions:") );
   lo->addWidget( gbToolbar );
+  connect( acSel, SIGNAL( added( QListBoxItem * ) ), this, SLOT( slotChanged() ) );
+  connect( acSel, SIGNAL( removed( QListBoxItem * ) ), this, SLOT( slotChanged() ) \
); +  connect( acSel, SIGNAL( movedUp( QListBoxItem * ) ), this, SLOT( slotChanged() \
) ); +  connect( acSel, SIGNAL( movedDown( QListBoxItem * ) ), this, SLOT( \
slotChanged() ) ); +
   // Sync
   QGroupBox *gbSync = new QGroupBox( 1, Qt::Horizontal, i18n("Auto \
Synchronization"), this );  cbSyncActive = new QCheckBox( i18n("When a docu&ment \
becomes active"), gbSync );  cbSyncOpen = new QCheckBox( i18n("When a document is \
o&pened"), gbSync );  cbSyncShow = new QCheckBox( i18n("When the file selector \
becomes visible"), gbSync );  lo->addWidget( gbSync );
+  connect( cbSyncActive, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
+  connect( cbSyncOpen, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
+  connect( cbSyncShow, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
 
   // Histories
   QHBox *hbPathHist = new QHBox ( this );
@@ -542,18 +550,22 @@ KFSConfigPage::KFSConfigPage( QWidget *p
   sbPathHistLength = new QSpinBox( hbPathHist );
   lbPathHist->setBuddy( sbPathHistLength );
   lo->addWidget( hbPathHist );
+  connect( sbPathHistLength, SIGNAL( valueChanged ( int ) ), this, SLOT( \
slotChanged() ) );  
   QHBox *hbFilterHist = new QHBox ( this );
   QLabel *lbFilterHist = new QLabel( i18n("Remember &filters:"), hbFilterHist );
   sbFilterHistLength = new QSpinBox( hbFilterHist );
   lbFilterHist->setBuddy( sbFilterHistLength );
   lo->addWidget( hbFilterHist );
+  connect( sbFilterHistLength, SIGNAL( valueChanged ( int ) ), this, SLOT( \
slotChanged() ) );  
   // Session
   QGroupBox *gbSession = new QGroupBox( 1, Qt::Horizontal, i18n("Session"), this );
   cbSesLocation = new QCheckBox( i18n("Restore loca&tion"), gbSession );
   cbSesFilter = new QCheckBox( i18n("Restore last f&ilter"), gbSession );
   lo->addWidget( gbSession );
+  connect( cbSesLocation, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
+  connect( cbSesFilter, SIGNAL( toggled( bool ) ), this, SLOT( slotChanged() ) );
 
   // make it look nice
   lo->addStretch( 1 );


["kdelibs_kate.applyop.patch" (text/x-diff)]

Index: part/katedialogs.cpp
===================================================================
RCS file: /home/kde/kdelibs/kate/part/katedialogs.cpp,v
retrieving revision 1.49
diff -u -p -r1.49 katedialogs.cpp
--- part/katedialogs.cpp	24 Mar 2003 11:08:30 -0000	1.49
+++ part/katedialogs.cpp	1 Apr 2003 13:45:11 -0000
@@ -286,6 +286,7 @@ void HlConfigPage::showEvent ( QShowEven
 
     page = new HighlightDialogPage(hlManager, &defaultStyleList, &hlDataList, 0, \
this);  grid->addWidget( page, 0, 0);
+    connect( page, SIGNAL( configChanged() ), this, SLOT( slotChanged() ) );
     page->show ();
 
     m_ready = true;
@@ -358,10 +359,13 @@ HighlightDialogPage::HighlightDialogPage
   QLabel *lFileExts = new QLabel( i18n("File e&xtensions:"), hbFE );
   wildcards  = new QLineEdit( hbFE );
   lFileExts->setBuddy( wildcards );
+  connect( wildcards, SIGNAL( textChanged ( const QString & ) ), this, SLOT( \
slotChanged() ) );  
   QHBox *hbMT = new QHBox( gbProps );
   QLabel *lMimeTypes = new QLabel( i18n("MIME &types:"), hbMT);
   mimetypes = new QLineEdit( hbMT );
+  connect( mimetypes, SIGNAL( textChanged ( const QString & ) ), this, SLOT( \
slotChanged() ) ); +
   QToolButton *btnMTW = new QToolButton(hbMT);
   btnMTW->setIconSet(QIconSet(SmallIcon("wizard")));
   connect(btnMTW, SIGNAL(clicked()), this, SLOT(showMTDlg()));
@@ -466,6 +470,11 @@ void HighlightDialogPage::showMTDlg()
   }
 }
 
+void HighlightDialogPage::slotChanged()
+{
+  emit configChanged();
+}
+
 /******************************************************************************/
 /*                     HlEditDialog implementation                            */
 /******************************************************************************/
@@ -1372,5 +1381,7 @@ SpellConfigPage::SpellConfigPage( QWidge
 	: Kate::ConfigPage( parent)
 {
 	QVBoxLayout* l = new QVBoxLayout( this );
-	l->addWidget( new KSpellConfig( this, 0L, config, false ) );
+	KSpellConfig *cPage = new KSpellConfig( this, 0L, config, false );
+	l->addWidget( cPage );
+	connect( cPage, SIGNAL( configChanged() ), this, SLOT( slotChanged() ) );
 }
Index: part/katedialogs.h
===================================================================
RCS file: /home/kde/kdelibs/kate/part/katedialogs.h,v
retrieving revision 1.27
diff -u -p -r1.27 katedialogs.h
--- part/katedialogs.h	24 Mar 2003 11:08:30 -0000	1.27
+++ part/katedialogs.h	1 Apr 2003 13:45:11 -0000
@@ -319,6 +319,11 @@ class HighlightDialogPage : public QTabW
     void hlNew();
     void hlDownload();
     void showMTDlg();
+    void slotChanged();
+
+  signals:
+    void configChanged();
+
   protected:
     KateAttributeList *defaultItemStyleList;
 
Index: part/kateviewdialog.cpp
===================================================================
RCS file: /home/kde/kdelibs/kate/part/kateviewdialog.cpp,v
retrieving revision 1.87
diff -u -p -r1.87 kateviewdialog.cpp
--- part/kateviewdialog.cpp	24 Mar 2003 11:08:30 -0000	1.87
+++ part/kateviewdialog.cpp	1 Apr 2003 13:45:12 -0000
@@ -144,28 +144,34 @@ IndentConfigTab::IndentConfigTab(QWidget
   opt[0] = new QCheckBox(i18n("A&utomatically indent"), this);
   layout->addWidget(opt[0], 0, AlignLeft);
   opt[0]->setChecked(configFlags & flags[0]);
+  connect( opt[0], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 
   opt[1] = new QCheckBox(i18n("Use &spaces to indent"), this);
   layout->addWidget(opt[1], 0, AlignLeft);
   opt[1]->setChecked(configFlags & flags[1]);
+  connect( opt[1], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 
   opt[3] = new QCheckBox(i18n("&Tab key indents"), this);
   layout->addWidget(opt[3], 0, AlignLeft);
   opt[3]->setChecked(configFlags & flags[3]);
+  connect( opt[3], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 
   opt[2] = new QCheckBox(i18n("&Backspace key indents"), this);
   layout->addWidget(opt[2], 0, AlignLeft);
   opt[2]->setChecked(configFlags & flags[2]);
+  connect( opt[2], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 
   opt[4] = new QCheckBox(i18n("Keep indent &profile"), this);
   layout->addWidget(opt[4], 0, AlignLeft);
   opt[4]->setChecked(configFlags & flags[4]);
+  connect( opt[4], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 //   opt[4]->setChecked(true);
 //   opt[4]->hide();
 
   opt[5] = new QCheckBox(i18n("&Keep extra spaces"), this);
   layout->addWidget(opt[5], 0, AlignLeft);
   opt[5]->setChecked(configFlags & flags[5]);
+  connect( opt[5], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 
   layout->addStretch();
 
@@ -215,10 +221,12 @@ SelectConfigTab::SelectConfigTab(QWidget
   opt[0] = new QCheckBox(i18n("&Persistent selections"), this);
   layout->addWidget(opt[0], 0, AlignLeft);
   opt[0]->setChecked(configFlags & flags[0]);
+  connect( opt[0], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 
   opt[1] = new QCheckBox(i18n("O&verwrite selected text"), this);
   layout->addWidget(opt[1], 0, AlignLeft);
   opt[1]->setChecked(configFlags & flags[1]);
+  connect( opt[1], SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
 
   layout->addStretch();
 
@@ -267,11 +275,13 @@ EditConfigTab::EditConfigTab(QWidget *pa
 
   opt[0] = new QCheckBox(i18n("Enable &word wrap"), gbWordWrap);
   opt[0]->setChecked(view->wordWrap());
+  connect(opt[0], SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
   connect(opt[0], SIGNAL(toggled(bool)), this, SLOT(wordWrapToggled()));
 
   e1 = new KIntNumInput(view->wordWrapAt(), gbWordWrap);
   e1->setRange(20, 200, 1, false);
   e1->setLabel(i18n("Wrap words at:"), AlignVCenter);
+  connect(e1, SIGNAL(valueChanged(int)), this, SLOT(slotChanged()));
 
   mainLayout->addWidget(gbWordWrap);
 
@@ -279,41 +289,50 @@ EditConfigTab::EditConfigTab(QWidget *pa
 
   opt[4] = new QCheckBox(i18n("&Show tabs"), gbWhiteSpace);
   opt[4]->setChecked(configFlags & flags[4]);
+  connect(opt[4], SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
 
   opt[1] = new QCheckBox(i18n("Replace &tabs with spaces"), gbWhiteSpace);
   opt[1]->setChecked(configFlags & flags[1]);
+  connect(opt[1], SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
 
   opt[2] = new QCheckBox(i18n("&Remove trailing spaces"), gbWhiteSpace);
   opt[2]->setChecked(configFlags & flags[2]);
+  connect(opt[2], SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
 
   e2 = new KIntNumInput(e1, view->tabWidth(), gbWhiteSpace);
   e2->setRange(1, 16, 1, false);
   e2->setLabel(i18n("Tab and indent width:"), AlignVCenter);
+  connect(e2, SIGNAL(valueChanged(int)), this, SLOT(slotChanged()));
 
   mainLayout->addWidget(gbWhiteSpace);
 
   opt[3] = new QCheckBox(i18n("Auto &brackets"), this);
   mainLayout->addWidget(opt[3]);
   opt[3]->setChecked(configFlags & flags[3]);
+  connect(opt[3], SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
 
   opt[5] = new QCheckBox(i18n("Smart ho&me"), this);
   mainLayout->addWidget(opt[5]);
   opt[5]->setChecked(configFlags & flags[5]);
+  connect(opt[5], SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
 
   opt[6] = new QCheckBox(i18n("Wrap c&ursor"), this);
   mainLayout->addWidget(opt[6]);
   opt[6]->setChecked(configFlags & flags[6]);
+  connect(opt[6], SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
 
   e4 = new KIntNumInput(view->autoCenterLines(), this);
   e4->setRange(0, 1000000, 1, false);
   e4->setLabel(i18n("Autocenter cursor (lines):"), AlignVCenter);
   mainLayout->addWidget(e4);
+  connect(e4, SIGNAL(valueChanged(int)), this, SLOT(slotChanged()));
 
   e3 = new KIntNumInput(e2, view->undoSteps(), this);
   e3->setRange(0, 1000000, 1, false);
   e3->setSpecialValueText( i18n("Unlimited") );
   e3->setLabel(i18n("Maximum undo steps:"), AlignVCenter);
   mainLayout->addWidget(e3);
+  connect(e3, SIGNAL(valueChanged(int)), this, SLOT(slotChanged()));
 
   mainLayout->addStretch();
 
@@ -391,6 +410,13 @@ ViewDefaultsConfig::ViewDefaultsConfig(Q
         m_bmSort->setRadioButtonExclusive( true );
         m_bmSort->insert( rb1=new QRadioButton( i18n("By &position"), m_bmSort ), 0 \
                );
         m_bmSort->insert( rb2=new QRadioButton( i18n("By c&reation"), m_bmSort ), 1 \
); +  connect(m_dynwrap, SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
+  connect(m_wwmarker, SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
+  connect(m_line, SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
+  connect(m_icons, SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
+  connect(m_folding, SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
+  connect(rb1, SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
+  connect(rb2, SIGNAL(toggled(bool)), this, SLOT(slotChanged()));
 	blay->addWidget(m_dynwrap,0);
         blay->addWidget( m_wwmarker, 0 );
   blay->addWidget(m_line,0);
@@ -461,29 +487,34 @@ ColorConfig::ColorConfig( QWidget *paren
   m_back = new KColorButton( this );
   glay->addWidget( label, 0, 0 );
   glay->addWidget( m_back, 0, 1 );
+  connect( m_back, SIGNAL( changed( const QColor & ) ), this, SLOT( slotChanged() ) \
);  
   label = new QLabel( i18n("Selected:"), this);
   label->setAlignment( AlignRight|AlignVCenter );
   m_selected = new KColorButton( this );
   glay->addWidget( label, 2, 0 );
   glay->addWidget( m_selected, 2, 1 );
+  connect( m_selected, SIGNAL( changed( const QColor & ) ), this, SLOT( \
slotChanged() ) );  
   label = new QLabel( i18n("Current line:"), this);
   label->setAlignment( AlignRight|AlignVCenter );
   m_current = new KColorButton( this );
   glay->addWidget( label, 4, 0 );
   glay->addWidget( m_current, 4, 1 );
+  connect( m_current, SIGNAL( changed( const QColor & ) ), this, SLOT( slotChanged() \
) );  
   label = new QLabel( i18n("Bracket highlight:"), this );
   label->setAlignment( AlignRight|AlignVCenter );
   m_bracket = new KColorButton( this );
   glay->addWidget( label, 6, 0 );
   glay->addWidget( m_bracket, 6, 1 );
+  connect( m_bracket, SIGNAL( changed( const QColor & ) ), this, SLOT( slotChanged() \
) );  
   label = new QLabel( i18n("Word wrap:"), this );
   label->setAlignment( AlignRight|AlignVCenter );
   m_wwmarker = new KColorButton( this );
   label->setBuddy( m_wwmarker );
+  connect( m_wwmarker, SIGNAL( changed( const QColor & ) ), this, SLOT( \
slotChanged() ) );  glay->addWidget( label, 7, 0 );
   glay->addWidget( m_wwmarker, 7, 1 );
 
@@ -567,6 +598,8 @@ FontConfig::FontConfig( QWidget *parent,
 
   connect (m_fontchooser, SIGNAL (fontSelected( const QFont & )), this, SLOT \
(slotFontSelected( const QFont & )));  connect (m_fontchooserPrint, SIGNAL \
(fontSelected( const QFont & )), this, SLOT (slotFontSelectedPrint( const QFont & \
))); +  connect (m_fontchooser, SIGNAL (fontSelected( const QFont & )), this, SLOT \
(slotChanged())); +  connect (m_fontchooserPrint, SIGNAL (fontSelected( const QFont & \
)), this, SLOT (slotChanged()));  
   reload ();
 }
@@ -627,6 +660,7 @@ void EditKeyConfiguration::showEvent ( Q
     (new QVBoxLayout(this))->setAutoAdd(true);
     KateView* view = (KateView*)m_doc->views().at(0);
     m_keyChooser = new KKeyChooser( view->editActionCollection(), this, false );
+    connect( m_keyChooser, SIGNAL( keyChange() ), this, SLOT( slotChanged() ) );
     m_keyChooser->show ();
 
     m_ready = true;
@@ -659,6 +693,9 @@ SaveConfigTab::SaveConfigTab( QWidget *p
   leBuSuffix = new QLineEdit( hbBuSuffix );
   lBuSuffix->setBuddy( leBuSuffix );
 
+  connect( cbLocalFiles, SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
+  connect( cbRemoteFiles, SIGNAL( toggled(bool) ), this, SLOT( slotChanged() ) );
+  connect( leBuSuffix, SIGNAL( textChanged ( const QString & ) ), this, SLOT( \
slotChanged() ) );  layout->addStretch();
 
   QWhatsThis::add( gb, i18n(
Index: tests/highlight.pl
===================================================================
RCS file: /home/kde/kdelibs/kate/tests/highlight.pl,v
retrieving revision 1.1
diff -u -p -r1.1 highlight.pl
--- tests/highlight.pl	10 Jan 2002 21:28:53 -0000	1.1
+++ tests/highlight.pl	1 Apr 2003 13:45:12 -0000
@@ -25,6 +25,7 @@ fsd sdf sdfsdlkf sd
 __EOF
 
 	$x = "dasds";
+	$x = "Couldn't write";
 
 	next if( $match eq "two" );
 	next if( $match =~ /go/i );


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic