[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Qt private includes used in KDE
From:       Ralf Nolden <nolden () kde ! org>
Date:       2003-02-06 19:54:33
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

while doing the Qt packaging with Martin Loschwitz for Debian, I tried to 
track down the files that get distributed with the Qt packages to be limited 
to the API that Qt offers (and thus should only be used by programmers). This 
means that the directory QTDIR/include/private and the underlying includes 
should not be distributed for any development use.

In that matter, Simon reminded me of some cases where we used these includes 
and hinted me to lxr.kde.org to find that out. I hope that maybe we have a 
chance to eliminate those dependencies which are obviously stemming from 
either unavoidable hacks because this part of Qt is not public or where the 
according class declarations should better be included in the code that needs 
it if it really cannot avoid using the private includes. 

Here is a listing of what I found in 3.1 so far, searching for private/q

 kdelibs/dcop/dcopclient.cpp, line 55 -- #include <private/qucomextra_p.h>
 kdelibs/khtml/khtml_ext.cpp, line 13 -- #include <private/qucomextra_p.h>
 kdelibs/khtml/khtml_part.cpp, line 94 -- #include <private/qucomextra_p.h>
 kdelibs/kparts/browserinterface.cpp, line 8 -- #include 
<private/qucomextra_p.h>
 kdebase/konqueror/konq_view.cc, line 43 -- #include <private/qucomextra_p.h>
 kdesdk/kbabel/kbabel/mymultilineedit.cpp, line 38 -- #include 
<private/qrichtext_p.h>

Then there's the fixincludes script that shouldn't really do this :-)

 kdesdk/scripts/fixincludes, line 71 -- 'qfiledef.h' => 
"private/qfiledefs_p.h",
 kdesdk/scripts/fixincludes, line 99 -- 'qpsprn.h' => 
"<private/qpsprinter_p.h>",


At least there is kde-common/admin/acinclude.m4.in that uses the include:

 kdelibs/admin/acinclude.m4.in, line 1069 -- #include <private/qucomextra_p.h>
 
- -- 
We're not a company, we just produce better code at less costs.
- --------------------------------------------------------------------
Ralf Nolden
nolden@kde.org

The K Desktop Environment       The KDevelop Project
http://www.kde.org              http://www.kdevelop.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+Qr18u0nKi+w1Ky8RAhbOAJ4ifS1StyJxGesdfWjJ3Gi8/Wdl+QCfYQFG
fJU9IWhnm6X+EcRhVLtNKDk=
=oWmb
-----END PGP SIGNATURE-----


 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]