[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: in-place-editing patch for konqueror bookmarks
From:       "Aaron J. Seigo" <aseigo () olympusproject ! org>
Date:       2002-12-29 18:44:06
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 29 December 2002 04:10, Oelewapperke wrote:
> On Sunday 29 December 2002 00:50, Aaron J. Seigo wrote:
> > On Saturday 28 December 2002 04:17, Oelewapperke wrote:
> > > 			-> not binary compatible (but I don't know any app other than konq
> > > that uses bookmarks)
> >
> > kate and kfiledialog to name two, and kfiledialog is used by most KDE
> > apps. not to mention all the third party apps that may or may not use it.
> > BC is not optional.
>
> kfiledialog is a part of kdelibs, just as bookmarks are, they are compiled
> together, and the interface of kfiledialog won't change. Same argument for
> kate. This is no problem I think.

yes, it is a problem since BC is an absolute requirement. there are other 
parts of KDE using it as i have already noted, and it is a public interface. 
this KDE policy, and is meant to ensure sane 3rd party development and stable 
end-user experiences.

as i said: BC is not optional.

> What does RMB mean ?

right mouse button

> I would really prefer to see some way to include things other than
> QMenuItems in the popups (the main problem is that one cannot draw them
> because KStyle cannot do without a QMenuItem :-( ), because doing it this
> way has a number of disadvantages I think.

you can insert a QWidget...

> Every single modification you make you have to add more code everywhere to
> avoid adding a bit of code to PopupMenu's and bookmarks (eg. drag and drop
> for bookmarks will require another subclass to avoid breaking BC ...). This
> code will only keep growing over time.

this code can be refactored when we break BC in the (far?) future 4.0 
release.. 

note that my patch to KPopupMenu doesn't add another subclass, it extends one 
in a BC way to provide RMB menus on menus. other features could likely be 
added in a similar fashion...

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

"Everything should be made as simple as possible, but not simpler"
    - Albert Einstein
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+D0J31rcusafx20MRAm0NAJ9XU5k197aXtxXoyT/M7APP2pgCrQCdHgmw
aJxEwS8bC0Mgf0f7rNJ8hMM=
=JVTi
-----END PGP SIGNATURE-----

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]