[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: in-place-editing patch for konqueror bookmarks
From:       Oelewapperke <oelewapperke () ulyssis ! org>
Date:       2002-12-29 11:10:29
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 29 December 2002 00:50, Aaron J. Seigo wrote:
> On Saturday 28 December 2002 04:17, Oelewapperke wrote:
> > 			-> not binary compatible (but I don't know any app other than konq
> > that uses bookmarks)
>
> kate and kfiledialog to name two, and kfiledialog is used by most KDE apps.
> not to mention all the third party apps that may or may not use it. BC is
> not optional.

kfiledialog is a part of kdelibs, just as bookmarks are, they are compiled 
together, and the interface of kfiledialog won't change. Same argument for 
kate. This is no problem I think.

> i'd actually like to see RMB menuing be added to KPopupMenu so that it can
> be used anywhere desired. i've got code here that provides this service as
> a subclass of KPopupMenu, but it could likely be added to KPopupMenu itself
> while maintaining BC. you can take a look at it at:
>
> http://urbanlizard.com/~aseigo/rmbMenu.h
> http://urbanlizard.com/~aseigo/rmbMenu.cc
>
> i'm using it in my task oriented menu thingy... i've merged it with
> KPopupMenu and produced a patch, which is attached... thoughts?

What does RMB mean ?

I would really prefer to see some way to include things other than QMenuItems 
in the popups (the main problem is that one cannot draw them because KStyle 
cannot do without a QMenuItem :-( ), because doing it this way has a number 
of disadvantages I think.

Every single modification you make you have to add more code everywhere to 
avoid adding a bit of code to PopupMenu's and bookmarks (eg. drag and drop 
for bookmarks will require another subclass to avoid breaking BC ...). This 
code will only keep growing over time.

Oelewapperke
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+Dtg2JFU6C5Uo8MgRAnosAJ4heU1u6J6BDNn7ON7+d/PWrSjFSgCeLcQj
vjyYIpeupLIqJQUj4m5JySI=
=AwVR
-----END PGP SIGNATURE-----

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]