[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] let dcop understand KURL::List
From:       Leif Jensen <jensen () cpw ! math ! columbia ! edu>
Date:       2002-12-05 18:50:16
[Download RAW message or body]

I made a simple patch so that the dcop command line utility could
understand arguments of type KURL::List.  This is useful for

dcop konqueror-#### KDirNotify-1 FilesChanged [ file:/some/file ]

This was intended to notify konqueror to update icon thumbnails
when a change is made (like jpegtran -rotate 90).  Unfortunately,
I can't get konqueror from recent cvs to update stale thumbnails.

Is this patch for dcop good?

Should something be done for the gui version kdcop too?

Is there a bug with konqueror not updating stale thumbnails?

Is the thumbnail: kioslave bugged now?  It gives me internal errors.

Patch below applies to kdelibs/dcop/client/marshall.cpp

Thanks,
Leif

diff -up client-orig/marshall.cpp client/marshall.cpp
--- client-orig/marshall.cpp    2002-12-05 13:45:22.000000000 -0500
+++ client/marshall.cpp 2002-12-05 13:45:19.000000000 -0500
@@ -314,8 +314,12 @@ void marshall( QDataStream &arg, QCStrin
            arg << QVariant( mkColor( s.mid(7, s.length()-8) ) );
        else
            arg << QVariant( s );
-    } else if ( type.startsWith("QValueList<")) {
-       type = type.mid(11, type.length() - 12);
+    } else if ( type == "KURL::List"
+          || type.startsWith("QValueList<")) {
+        if (type == "KURL::List")
+          type = "KURL";
+        else
+         type = type.mid(11, type.length() - 12);
        QStringList list;
        QString delim = s;
        if (delim == "[")

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]