[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KDE patches from PLD.
From:       Adam Gorzkiewicz <adgor () isn ! pl>
Date:       2002-11-29 0:25:20
[Download RAW message or body]

Dnia Thursday 28 of November 2002 22:21, Daniel Molkentin napisał:
> On Thursday 28 November 2002 22:13, Piotr Szymanski wrote:
> >Dirk Mueller (Thursday 28 of November 2002 21:58):
> >> What is this supposed to fix ?
> >
> >kscd in kde 3.0.8 used to crash without this. Babling about undefined
> >hotkey...
>
> Yeah, and with this patch, it breaks the slot :(
>
> +  action = new KAction(i18n("Options"), CTRL + Key_T, this,
> SLOT(showConfig), this, "Options");
>
> it needs to be showConfig>>()<<....

You're right. :)
It was accidently brokem with last upgrade. I'm attaching working one.

Second thing: without this patch kscd babling about undefined hotkey, but 
never crash. There was problem with crashing kscd in kde 3.0.8 but not 
with this reason. However I thought so at that time and wrote my opinion 
to Piotr. The result was that Hi was wrong.

I'm Sorry for some confusion :>

Regards

-- 
Adam Gorzkiewicz
PLD Linux Developer
adgor@isn.pl
adgor@pld.org.pl

["kdemultimedia-kscd.patch" (text/x-diff)]

diff -urN kdemultimedia-3.0.9.orig/kscd/kscd.cpp kdemultimedia-3.0.9/kscd/kscd.cpp
--- kdemultimedia-3.0.9.orig/kscd/kscd.cpp	Mon Oct 28 10:59:49 2002
+++ kdemultimedia-3.0.9/kscd/kscd.cpp	Thu Oct 31 23:38:48 2002
@@ -279,7 +279,7 @@
   action->plugAccel(accels);
   action = new KAction(i18n("Decrease Volume"), Key_Minus, this, SLOT(decVolume()), this, "DecVolume");
   action->plugAccel(accels);
-  action = new KAction(i18n("Options"), CTRL + Key_T, this, SLOT(showConfig()), this);
+  action = new KAction(i18n("Options"), CTRL + Key_T, this, SLOT(showConfig()), this, "Options");
   action->plugAccel(accels);
   action = new KAction(i18n("Shuffle"), Key_R, this, SLOT(randomSelected()), this, "Shuffle");
   action->plugAccel(accels);

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]