[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KDE patches from PLD.
From:       Dirk Mueller <mueller () kde ! org>
Date:       2002-11-28 21:13:18
[Download RAW message or body]

On Don, 28 Nov 2002, Piotr Szymanski wrote:

> + from Rawhide
> kdeutils-kedit-confirmoverwrite.patch

Whats the sense of bugging the user with a popup till he says "yes" ?

Another one: 

--- kdebase-3.1/konsole/konsole/konsole.cpp.orig        Sat Nov 23 19:06:02 
2002
+++ kdebase-3.1/konsole/konsole/konsole.cpp     Mon Nov 25 19:10:25 2002
   //help menu
-  m_help->setAccel(QKeySequence(),m_help->idAt(0));
-
+  


you really don't want to patch this out. 


@@ -1864,7 +1863,7 @@
 
 QString Konsole::newSession(KSimpleConfig *co, QString program, const 
QStrList &args, const QString &_term,const QStr
ing &_icon,const QString &_title, const QString &_cwd)
 {
-  QString emu = "xterm";
+  QString emu = "xterm-color";


Huh???

> + from MDK
> kdeutils-fix-kdf-mem-leak.patch

Which memleak is this supposed to fix ? the dialog kept in background 
available once created, so it won't get deleted until kdf is closed. 

But the way your patch does it will crash the application because of a 
double deletion. 

-- 
Dirk (received 575 mails today)
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]