[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] Fix for Cervisia bug 50056
From:       Christian Loose <christian_loose () gmx ! de>
Date:       2002-11-05 19:41:42
[Download RAW message or body]

Hello!

please review the following patch for the bug 50056 
(http://bugs.kde.org/show_bug.cgi?id=50056).

Problem:

If the user wants to edit a file that is not writable for him and the option 
"Do cvs edit Automatically When Necessary" is activated then Cervisia 
executes the command 'cvs -f edit'. This activates the edit mode for all 
files in the project! I think the problem is the break statement after the 
"isWritable()" check.

Solution:

I think the reason for the "isWritable()" check is to make sure that the cvs 
edit command is executed only for non-writable files. I changed the source
accordingly.

Okay to commit?

Christian

["bug-50056.patch" (text/x-diff)]

Index: cervisiapart.cpp
===================================================================
RCS file: /home/kde/kdesdk/cervisia/cervisiapart.cpp,v
retrieving revision 1.41
diff -u -r1.41 cervisiapart.cpp
--- cervisiapart.cpp	2002/10/17 14:07:14	1.41
+++ cervisiapart.cpp	2002/11/05 18:52:56
@@ -641,11 +641,9 @@
                     if (!QFileInfo(*it).isWritable())
                         {
                             doit = true;
-                            break;
+                            cmdline += " ";
+                            cmdline += KShellProcess::quote(*it);
                         }
-
-                    cmdline += " ";
-                    cmdline += KShellProcess::quote(*it);
                 }
 
             if (doit)

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]