[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] XMLGUIfy kiconedit
From:       George Staikos <staikos () kde ! org>
Date:       2002-10-07 4:58:06
[Download RAW message or body]

On October 7, 2002 00:45, ben@meyerhome.net wrote:
> Yah! Glad to see more applications getting converted over that havn't been.
> 8 months ago or so I converted a dozen or so apps, but know that there are
> more.  Maybe we should start up a KDE-Janitors group to go around and fix
> up old/abandoned kde apps to the new kde technology. Such things as
>
> -Making sure all app use XMLUI/KAction stuff
> -Making sure GCC3.2 compiles and fixing any errors
> -Making sure they don't have icons that kde already has
> -Converting all of the current kde games to use the KGamesLib (Or those
> that are left)
> -Making sure they all use the KDEAboutBox
> -Making sure they all use KWidget vs QWidget (KApplication vs QApplication
> for example)
> -Removing any calls and or classes that are outdated with the new ones.
> -Remove any custom QInputDialog etc classes that were made by developers
> who didn't know enough of Qt
> -Removing all C calls for replacemnt Qt calls that exists (use
> QDateTime!!!) -Making sure they all use the args class and not their own
> string parsing -Using the built in icon loader, kconfig, library loading
> etc (i.e. dump the custom duplicate code!)
> -Removing X11 calls when not really needed or putting them in ifdefs for a
> possible fb version of kde
> etc, etc

  Please dont' take these things too lightly.  It happens all to often that 
someone with good intentions changes code to update to new infrastructure and 
breaks it in subtle ways.  A lot of this code has gone through many cycles of 
bug fixing and changing it could certainly change its behaviour.  Though I 
agree that code should be constantly maintained and updated, it must be done 
with much care, and often the correct fix is to leave it as is with a 
suitable comment.

-- 

George Staikos

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]