[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Tabbed Browsing usability issue
From:       Ladislav Strojil <Ladislav.Strojil () seznam ! cz>
Date:       2002-08-05 8:07:02
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 05 August 2002 08:46, Doug Hanley wrote:
> On Sunday 04 August 2002 05:31 pm, Randy Pearson wrote:
> > Hi All,
> >
> > The attached patch adds the ability to switch between tabs in Konqueror
> > using Shift+Left or Shift+Right keys.  I chose those keys since they are
> > already used this way in Konsole.
> >
> > I don't have CVS access (at least not yet), so if someone with CVS access
> > would review and commit, I would appreciate it.
> >
> > Thanks,
> > Randy
>
> I like the patch, but I think it would be cleaner to use
> currentPageIndex(), i've attatched a modified version that does that, your
> thoughts?
>
> btw, it also takes out some error checks that were no longer needed, and
> changes the icon names in the KActions constructors.

How does this behave when pressing Shift-Left/Right in a textarea or an 
editbox? Does it still select text, or does it now switch the tabs? If so, I 
would see this as a serious flaw.

Cheers,
Lada

- -- 
    ~       Ladislav Strojil, MFF UK
  ' v '               
 //   \\              
/(     )\    Powered by Penguin.
  ^ ' ^
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9TjImTnMZPFqq4nwRAhfSAKDKL2PxrzGuthIP3eh27f/jq18WFwCePQ7I
FmmG2BwOgcvKmsTR6wXOP08=
=K3h2
-----END PGP SIGNATURE-----


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]