[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: arts with libvorbis 1.0
From:       Dan Stone <dan () headzofstate ! com>
Date:       2002-07-24 19:59:51
[Download RAW message or body]

> > Yeah, we'd been talking about this for a bit earlier, both on this list
> > and for a distro I help out with from time to time, LFS (Linux From
> > Scratch)...it seems the new parameter is the maximum amount of samples
> > you want returned from that call ... have you tested out the aRts server
> > you built with these changes?  I was hoping someone with better knowledge
> > of the timing of things in aRts would help me out with establishing a
> > value for it...
>
> The stuff is stilll compiling.  What was the behavior of ov_read_float() in
> rc3? How many samples was it reading?
 I posted this to kde-devel a couple days ago..but here's a quick repost of a 
comparison between rc3 and 1.0final:

1.0rc3:
long ov_read_float(OggVorbis_File *vf,float ***pcm_channels,int *bitstream) {
[some code snipped here]
        float **pcm;
        long samples=vorbis_synthesis_pcmout(&vf->vd,&pcm);
        if(samples){
                if(pcm_channels)*pcm_channels=pcm;
                vorbis_synthesis_read(&vf->vd,samples);
[and so on]

1.0 final:
long ov_read_float(OggVorbis_File *vf,float ***pcm_channels,int length,int 
*bitstream){
[same code snipped here]
        float **pcm;
        long samples=vorbis_synthesis_pcmout(&vf->vd,&pcm);
        if(samples){
                if(pcm_channels)*pcm_channels=pcm;
                if(samples>length)samples=length;
                vorbis_synthesis_read(&vf->vd,samples);
[and so on]

So it actually just added in the parameter and the option to limit it, from 
what I can tell...although I can't seem to find any note concerning *why* it 
was done...may have been some bug or exploit involving it, but no one made 
any mention of it when fixing it, it seems...

~D. A. Stone

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]