[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Untranslated copyright in About box
From:       Stefan =?iso-8859-1?q?Asserh=E4ll?= <stefan.asserhall () telia ! com>
Date:       2002-07-07 15:42:01
[Download RAW message or body]

Hello,

I noticed that the copyright string in About boxes is not 
translated, because a call to i18n is missing for the 
copyright message in kdelibs/kdecore/kaboutdata.h. 

Here is a patch. I added a method in kaboutdata.cpp to 
return the copyright string. I hope this doesn't break 
binary compatibility. Otherwise klocale.h would have to 
be included in kaboutdata.h, which I think is best to avoid.

Should I commit to CVS?

/ Stefan Asserhäll

["kdelibs-kdecore.diff" (text/x-diff)]

Index: kaboutdata.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kaboutdata.cpp,v
retrieving revision 1.15
diff -u -3 -p -r1.15 kaboutdata.cpp
--- kaboutdata.cpp	23 Sep 2001 23:05:15 -0000	1.15
+++ kaboutdata.cpp	7 Jul 2002 15:08:52 -0000
@@ -337,3 +337,11 @@ KAboutData::license() const
   return result;
 }
 
+QString
+KAboutData::copyrightStatement() const
+{
+   if (mCopyrightStatement)
+      return i18n(mCopyrightStatement);
+   else
+      return QString::null;
+}
Index: kaboutdata.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kaboutdata.h,v
retrieving revision 1.24
diff -u -3 -p -r1.24 kaboutdata.h
--- kaboutdata.h	3 Mar 2002 21:20:25 -0000	1.24
+++ kaboutdata.h	7 Jul 2002 15:08:52 -0000
@@ -374,7 +374,7 @@ class KAboutData
     /**
      * @return the copyright statement.
      */
-    QString copyrightStatement() const { return( QString::fromLatin1(mCopyrightStatement )); }
+    QString copyrightStatement() const;
 
 
   private:


[prev in list] [next in list] [prev in thread] [next in thread]