[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: QMouseEvent button/state
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2002-06-30 19:39:20
[Download RAW message or body]

On Sunday 30 June 2002 12:15, Aaron J. Seigo wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Sunday 30 June 2002 10:43, Gioele Barabucci wrote:
> > * If a button is not Right, then it is Center or Left.
> > * if it is Right then it will never be Left at the same time (it could be
> > _also_ Left, but "!= LeftButton" is not "! & LeftButton")
> >
> > what was the author looking for?
>
> whether it was the author's intention or not, it prevents a menu from
> appearing if you click the RMB while you are in the middle of a left click.
>
> e.g.: "LMB down -> RMB down -> LMB up" would not result in showMenu(..)
> being emitted.
>
> strange indeed, and inconsistent with behaviour elsewhere in kde (including
> kpager). i don't see the point of it myself and your change looks good =)

When you find strange looking code, cvs annotate is always a good idea. In 
this case, the code is like that specifically to fix a bug produced by the 
behavior Aaron just described. In other words, don't change it. Though, 
adding a comment would probably be a good idea. :)

-John
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]