[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [kde-solaris] Fwd: Bug#44096: One system include file (net/if.h)
From:       Michael Matz <matz () kde ! org>
Date:       2002-06-19 16:31:36
[Download RAW message or body]

Hi,

On Wed, 19 Jun 2002, Eva Brucherseifer wrote:

> In the sources there is something like a fix, but it doesn't look very nice:
> #ifdef USE_SOLARIS
> /* net/if.h is incompatible with STL on Solaris 2.6 - 2.8, redefine
>    map in the header file because we don't need it. -- Simon Josefsson */
> #define map junkmap
> #endif
> #  include <net/if.h>
> #ifdef USE_SOLARIS
> #undef map
> #endif
>
> Matze told me, that USE_SOLARIS is set by libtool - so maybe this guy has a
> problem with libtool? Maybe his perl version is tool old?

Actually -DUSE_SOLARIS is added to CPPFLAGS in configure (in
acinclude.m4.in's KDE_CHECK_PTHREAD_OPTION, which is required from
KDE_CHECK_THREADING, which in turn is called from a macro used
everywhere).  So, hmm, normally he should get the -DUSE_SOLARIS on the
compile line.  Hard to know without some command logs from him.

> In the sources I couldn't find the place where stl_map.h is included - is it
> really stl_map.h directly? I hope not. It acutally should be <map>.

It's probably Qt itself which includes it (configured without
--disable-stl, or what it was called).

> In the sources quite often the old way of including standard headers is used.
> Is there any particular reason to do so? The ANSI standard was made in 1998
> so I think it's time to do it standard conform...

At least IRIX' MIPSpro compiler wasn't standard conformant (the cxxx
headers at least were missing).  Don't change what doesn't fail ;)  Maybe
when gcc 3.x is more available.

> Instead of switching to the std namespace completly one also can (or should)
> use std:: to address all standard classes/functions/etc. Maybe that also
> helps here.

I would hope that this had helped here, yes.  (At least when one doesn't
use 'using namespace std').  But if I'm right above, it's Qt which needs
to change it's includes.  And with g++ 2.95x (which ignore the std
namespace completely) it wouldn't have helped.


Ciao,
Michael.

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]