[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: kdemultimedia configure search ignores --with-extra-... ?
From: Pavel Troller <patrol () sinus ! cz>
Date: 2002-05-31 4:55:13
[Download RAW message or body]
Hi!
I did my best and repaired almost all cases except one.
The problem is that various packages, like ogg/vorbis, are searched
at many, many places. Many projects were integrated into kdemultimedia now
and they come with their own checks for various things, which are
very different from case to case, although they search for absolutely
the same.
I was unable to fix ogg/vorbis search in k3b, which is as follows
(excerpt from its configure.in.in)
OGG_VORBISLIBS=""
AC_MSG_CHECKING(for ogg/vorbis headers)
CPPFLAGS="$CPPFLAGS $KDE_INCLUDES" <<< This one added by me but didn't help
<<< See below
ogg_vorbis=no
AC_TRY_COMPILE([
#include <vorbis/codec.h>
#include <vorbis/vorbisfile.h>
],[
],[
ogg_vorbis=yes
])
AC_MSG_RESULT($ogg_vorbis)
I don't know how to integrate additional search paths into the CPPFLAGS
- something like $KDE_EXTRA_INCLUDES doesn't exist and $kde_extra_includes
is just a list with no -I before the actual paths.
Checks at other place require that I have to pass two more parameters
into the configure - --with-ogg-prefix=/opt/sound and
--with-vorbis-prefix=/opt/sound - I was unable to unify them to search at
$kde_extra_include/libs.
>
> Ogg vorbis check is in kdemultimedia/configure.in.in and but use $USER_*
> defines who use the extra_* specified paths
This one was never problematic. The other 3 or 4 from other packages were
(and one still is).
>
> for "cdparanoia" error it's in
> kdemultimedia/kioslave/audiocd/configure.in.in (add the missing
> $kde_extra_includes)
This one is fixed.
>
> and try to correct the AC_PATH_CDPARANOIA macro definition in
> kdemultimedia/kreatecd/configure.in.in (KDE_FIND_PATH must contain all
> possible paths for binaries)
Not necessary to touch - binaries are found automatically, probably because
they are all covered by the standard $PATH.
I also fixed strange complaints "CC: command not found" and similar
coming also from k3b configure.in.in - I think that improper parentheses were
used.
I'm attaching my fixes - however, I think they are just a kludge. The better
way would be to make one centralized check for all the things and distribute
its result to the packages which currently make its own checks. But I'm not
so familiar with auto* stuff to be able to do it myself, sorry.
With regards, Pavel Troller
["diff.out" (text/plain)]
Index: k3b/configure.in.in
===================================================================
RCS file: /home/kde/kdemultimedia/k3b/configure.in.in,v
retrieving revision 1.21
diff -u -3 -p -r1.21 configure.in.in
--- k3b/configure.in.in 28 May 2002 18:31:42 -0000 1.21
+++ k3b/configure.in.in 31 May 2002 04:38:10 -0000
@@ -1,11 +1,11 @@
#MIN_CONFIG
-CCAS=$(CC)
-CCASFLAGS=$(CFLAGS)
+CCAS=${CC}
+CCASFLAGS=${CFLAGS}
AC_SUBST(CCAS)
AC_SUBST(CCASFLAGS)
-AS=$(CC)
-ASFLAGS=$(CFLAGS)
+AS=${CC}
+ASFLAGS=${CFLAGS}
AC_SUBST(AS)
AC_SUBST(ASFLAGS)
@@ -38,7 +38,7 @@ AC_ARG_WITH(cdparanoia,
if test "x$with_cdparanoia" = "xCHECK" ; then
with_cdparanoia=NOTFOUND
- search_incs="$kde_includes /usr/include /usr/local/include /usr/include/cdda /usr/local/include/cdda"
+ search_incs="$kde_includes $kde_extra_includes /usr/include /usr/local/include /usr/include/cdda /usr/local/include/cdda"
AC_FIND_FILE(cdda_interface.h, $search_incs, para_incdir)
if test -r $para_incdir/cdda_interface.h ; then
test "x$para_incdir" != "x/usr/include" && CDPARANOIA_INCS="-I$para_incdir"
@@ -48,7 +48,7 @@ if test "x$with_cdparanoia" = "xCHECK" ;
with_cdparanoia=NOTFOUND
# because of the horrible hack we need shared cdparanoia
for ext in la so sl a ; do
- AC_FIND_FILE(libcdda_paranoia.$ext, $kde_libraries /usr/lib /usr/local/lib,
+ AC_FIND_FILE(libcdda_paranoia.$ext, $kde_libraries $kde_extra_libs /usr/lib /usr/local/lib,
para_libdir)
if test -r $para_libdir/libcdda_paranoia.$ext ; then
if test "x$para_libdir" != "x/usr/lib" ; then
@@ -106,6 +106,7 @@ AC_SUBST(CDPARANOIA_LIBS)
OGG_VORBISLIBS=""
AC_MSG_CHECKING(for ogg/vorbis headers)
+CPPFLAGS="$CPPFLAGS $KDE_INCLUDES"
ogg_vorbis=no
AC_TRY_COMPILE([
#include <vorbis/codec.h>
Index: kioslave/audiocd/configure.in.in
===================================================================
RCS file: /home/kde/kdemultimedia/kioslave/audiocd/configure.in.in,v
retrieving revision 1.22
diff -u -3 -p -r1.22 configure.in.in
--- kioslave/audiocd/configure.in.in 24 May 2002 22:49:02 -0000 1.22
+++ kioslave/audiocd/configure.in.in 31 May 2002 04:38:10 -0000
@@ -16,7 +16,7 @@ AC_ARG_WITH(cdparanoia,
if test "x$with_cdparanoia" = "xCHECK" ; then
with_cdparanoia=NOTFOUND
- search_incs="$kde_includes /usr/include /usr/local/include /usr/include/cdda /usr/local/include/cdda"
+ search_incs="$kde_includes $kde_extra_includes /usr/include /usr/local/include /usr/include/cdda /usr/local/include/cdda"
AC_FIND_FILE(cdda_interface.h, $search_incs, para_incdir)
if test -r $para_incdir/cdda_interface.h ; then
test "x$para_incdir" != "x/usr/include" && CDPARANOIA_INCS="-I$para_incdir"
@@ -26,7 +26,7 @@ if test "x$with_cdparanoia" = "xCHECK" ;
with_cdparanoia=NOTFOUND
# because of the horrible hack we need shared cdparanoia
for ext in la so sl a ; do
- AC_FIND_FILE(libcdda_paranoia.$ext, $kde_libraries /usr/lib /usr/local/lib,
+ AC_FIND_FILE(libcdda_paranoia.$ext, $kde_libraries $kde_extra_libs /usr/lib /usr/local/lib,
para_libdir)
if test -r $para_libdir/libcdda_paranoia.$ext ; then
if test "x$para_libdir" != "x/usr/lib" ; then
@@ -98,7 +98,7 @@ AC_ARG_ENABLE(lametest,
if test "x$with_lame" = "xCHECK" ; then
with_lame=NOTFOUND
- search_incs="/usr/local/include $kde_includes /usr/include"
+ search_incs="/usr/local/include $kde_includes $kde_extra_includes /usr/include"
AC_FIND_FILE(lame/lame.h, $search_incs, lame_incdir)
if test -r $lame_incdir/lame/lame.h ; then
test "x$lame_incdir" != "x/usr/include" && LAME_INCS="-I$lame_incdir"
@@ -107,7 +107,7 @@ if test "x$with_lame" = "xCHECK" ; then
if test $with_lame = FOUND ; then
with_lame=NOTFOUND
for ext in la so sl a ; do
- AC_FIND_FILE(libmp3lame.$ext, /usr/local/lib $kde_libraries /usr/lib,
+ AC_FIND_FILE(libmp3lame.$ext, /usr/local/lib $kde_libraries $kde_extra_libs /usr/lib,
lame_libdir)
if test -r $lame_libdir/libmp3lame.$ext ; then
if test "x$lame_libdir" != "x/usr/lib" ; then
@@ -246,7 +246,7 @@ AC_ARG_ENABLE(vorbistest,
have_vorbis_value=1
if test "x$with_vorbis" = "xCHECK" ; then
with_vorbis=NOTFOUND
- search_incs="$kde_includes /usr/local/include /usr/include"
+ search_incs="$kde_includes $kde_extra_includes /usr/local/include /usr/include"
AC_FIND_FILE(vorbis/codec.h, $search_incs, vorbis_incdir)
if test -r $vorbis_incdir/vorbis/codec.h ; then
test "x$vorbis_incdir" != "x/usr/include" && VORBIS_INCS="-I$vorbis_incdir"
@@ -257,7 +257,7 @@ if test "x$with_vorbis" = "xCHECK" ; the
if test $with_vorbis = FOUND ; then
with_vorbis=NOTFOUND
for ext in la so sl a ; do
- AC_FIND_FILE(libvorbis.$ext, $kde_libraries /usr/local/lib /usr/lib,
+ AC_FIND_FILE(libvorbis.$ext, $kde_libraries $kde_extra_libs /usr/local/lib /usr/lib,
vorbis_libdir)
if test -r $vorbis_libdir/libvorbis.$ext ; then
if test "x$vorbis_libdir" != "x/usr/lib" ; then
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic