[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: KKeyDialog and KAccel
From:       Ellis Whitehead <kde () ellisw ! net>
Date:       2002-05-08 11:59:28
[Download RAW message or body]

Hi Andi,

Great find!  Patch looks good.  Please commit. ;)

Cheers,
Ellis

On Wednesday 08 May 2002 07:31, Andreas Beckermann wrote:
> Hi
>
> On Tuesday 07 May 2002 18:17, Ellis Whitehead wrote:
> > > One more little thing - again, it's no big problem - with KAccel it was
> > > possible to configure single "regular" keys (such as 'p'), now the
> > > configure-dialog will only accept those in combination with a
> > > modifier-key.
> >
> > For the sake of backwards compatibility to KDE 2.x, the default is in
> > fact to allow unmodified letter-keys:
> >
> > 	KKeyChooser( ..., bAllowLetterShortcuts = true );
> > 	KKeyDialog( bool bAllowLetterShortcuts = true, ... );
> >
> > I suspect that 'false' is being passed to one of the above constructors.
>
> I just looked at the code:
> in the static KKeyDialog::configure() methods:
> KKeyDialog dlg( parent );
>
> And the only constructor:
> KKeyDialog( bool bAllowLetterShortcuts = true, QWidget* parent = 0, const
> char* name = 0 );
>
> So if a NULL parent is provided, bAllowLetterShortcuts will be false. The
> parent is always NULL if you use KKeyDialog::configure()
>
> Patch attached (I don't want to commit to kdelibs without review).
> I added a bAllowLetterShortcuts to the end of the parameter list, so source
> compatibility remains.
>
> > Regards,
> > Ellis
>
> CU
> Andi

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]