[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Open in current window
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-05-07 12:07:32
[Download RAW message or body]

On Monday 29 April 2002 21:43, jonathan_brugge wrote:
> I always dislike sites that make me open way too many Konqueror-windows by 
> using "target=_blank" and the like when it's not needed. Now I wrote a small 
> patch for Konqueror, so you have the option not to open a new window but 
> rather open the link in the current window. I suppose I didn't use the best 
> way to code this, but as it's only my second look at C/C++ code I just 
> decided to mimic slotPopupNewTab(). 

Hmm, I'm not too happy about the way that action is plugged into the popupmenu ;)
(even the new tab one, I mean).
KonqPopupMenu should plug it by name, and KonqMainWindow should simply
add the action to the collection it's passing to KonqPopupMenu.
That's what I'm doing right now to fix "Paste" btw (just mentionning this
to avoid conflicts ;)

> A good thing to implement might be to only show the 'open in current 
> window'-option when the link wants to open a new window, so the menu doesn't 
> get too cluttered with options that aren't of any use in a particular 
> situation.

That was what I was going to suggest, yes. I think this option would look very
confusing otherwise. But it's not easy to detect such a thing from Konqueror
I'm afraid. The target of the link ... is something very specific to khtml.
(Anyway, now that there is tabbed browsing, isn't "open in a new tab" good enough
to avoid a new window being created?)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KDE, Making The Future of Computing Available Today

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]