[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] focus locationbar in new tab
From:       Doug Hanley <hanleyman () adelphia ! net>
Date:       2002-04-28 21:09:06
[Download RAW message or body]

On Sunday 28 April 2002 06:51 am, jonathan_brugge wrote:
> The attatched patch gives focus to the locationbar when a new tab is added.
> The only reason I can think of to open a tab is to browse, which needs an
> URL typed in the locationbar, which means in turn that it should get focus.
> Note that this is my first patch ever (in fact, my first C or C++ code
> too), so there might be better ways to do this. I used focusLocationBar(),
> but the rest of the code uses m_combo->setFocus();. Makes me wonder why
> focusLocationBar() was ever written, as that does just the same (though
> it's easier to see what it does than m_combo->setFocus()).

I just applied your patch to CVS.

I'm not sure why they made that function then didn't use it, but you might as 
well use it if its there.

Excellent work.

-- Doug
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]