[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Abnormal behavior with Icons
From:       fenix <fenix () club-internet ! fr>
Date:       2002-04-14 17:07:07
[Download RAW message or body]

Le dim 14/04/2002 à 17:57, Torsten Rahn a écrit :
> > PS: after some tests with kde apps:
> >  - kicker, konsole, ... use the good icon
> >  - konqueror, kopete, noatun, kate, ... continue using the old icon
> 
> Actually It's vice versa:
> 
> kicker and konsole use the "go"-icon which is part of kdebase. This is a bad 
> solution as other (which are not part of kdebase) apps might copy the code 
> which "misuses" the icon. After all kdebase is an _optional_ (though 
> recommended part) of KDE and therefore the apps might not find the icon if 
> kdebase is not installed.
> 
> Therefore konqueror, kopete, noatun, .. use the good icon (which is named 
> "about_kde" iirc).

but in kdelibs/kdeui/khelpmenu.cpp at KHelpMenu::menu() line 159 i have
found:

...
 if (kapp->authorizeKAction("help_about_kde"))
    {
      mMenu->insertItem( SmallIcon("go"), i18n( "About &KDE" ),
menuAboutKDE );
      mMenu->connectItem( menuAboutKDE, this, SLOT( aboutKDE() ) );
    }
...

with this code all apps who are using KMainWindow (who use KHelpMenu, cf
KMainWindow::helpMenu and KMainWindow::customHelpMenu) must have
"go"-icon as icon for "About KDE"

Nor kopete and nor noatun are using directly KHelpMenu, they use
KMainWindow with KAboutData/KCmdLineArgs initialisation.

I don't understand why the same code can initialize menu with differents
icons ;(

Ans I have seen only this problem with 16x16 icons

> Tackat
>  

FeniX

PS: the same problem happened in some others menus: in my kicker menu,
the Preferences icon is the hicolor version of configure.png but in
konqueror settings menu it's the crystal version ;(


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]