[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    RE: Folder mimetype thing
From:       Simon MacMullen <simon.macmullen () aspect-proteus ! com>
Date:       2002-04-05 9:38:26
[Download RAW message or body]

David:
> Looks good to me, except that I see an unrelated change,
> the disabling of fixed sizes for image previews in 
> konq_iconviewwidget.cc

Arrrgh! I did this on my own build because I prefer it that way - I really
really really promise not to commit it. Really.

Although it might be nice to make this optional at some point - I think
previews should be the same size as other icons, that way you don't get
jumping when they've finished.

> The rest looks good - but the naming of the option must be 
> changed, that's
> for sure ;) The word "mimetype" isn't in the GUI anywhere, we 
> say "file type"
> at least (but the other suggestions on this list looked even better).

I am now intending to go with Marten's "Folder icons 
reflect contents". Thanks for all the suggestions everyone.

> BTW even in the code, the name folder-mimetype is 
> confusing/wrong, IMHO.
> Folder mimetypes are something that might come up later, i.e. 
> mimetypes
> derived from inode/directory, to represent e.g. hosts etc.
> A better name for your class could be KIVDirectoryOverlay.

OK.

> And a nitpick before coolo cries:
> +    if (d->m_folderMimeType) delete d->m_folderMimeType;
> Remove the if(), it's useless ;)

You can probably guess that I write Java in my day job.
 
> I also hope that all this dir-listing doesn't slow things 
> down too much (good that it's optionnal ;)

Well, I wouldn't recommend it for FTP over a modem, but it's OK.

By the way (David, since you seem to spend 95% of your time helping newbies
and the other 95% coding), how can I get the view to refresh? I can't see
any slots in KonqKfmIconView or KonqDirPart to do this.

Thanks, Simon
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]