[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH]Konsole: Unix98 ttys this time it works
From:       "Chris January" <chris () atomice ! net>
Date:       2002-04-03 23:09:07
[Download RAW message or body]

> [dunno if konsole-devel accepts who is not subscribed, so i'm sending this
> also to kde-devel]
>
> Ok, last time you said that it could not be incorporated because of the
> feature freeze... this time I hope it will go in for 3.1.
>
> Changes:
> - ability to open a new device on a /dev/pts/ UNIX98 filesystem (that
should
> be used by all and is used by cgywin).
> - konsole_granpty is able to chown tty/pty under /dev/pts/ (so we avoid
> eavesdropping it)
>
> Three notes:
> 1) I've modified this:
> -int chownpty(int fd, int grant)
> +int chownpty(int fd, bool grant)
> and changed where necessary, it this ok?
>
> 2) this is more explicit IMO
> -  if (!strcmp(argv[1],"--grant"))
> +  if (strcmp(argv[1],"--revoke"))
>
> 3) Please add the configure.in.in test in konsole/configure.in.in dir,
this
> where it belongs, but I've no way to create a new file and make it "cvs
> diff"-ed, so I had to add in in kdebase/configure.in.in
I've tested this under Cygwin and it works.

Chris


 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]